Forward blocks to parent in block-blockrange views#282
Open
jishnub wants to merge 1 commit intoJuliaArrays:masterfrom
Open
Forward blocks to parent in block-blockrange views#282jishnub wants to merge 1 commit intoJuliaArrays:masterfrom
jishnub wants to merge 1 commit intoJuliaArrays:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
==========================================
- Coverage 92.18% 92.16% -0.02%
==========================================
Files 16 16
Lines 1484 1481 -3
==========================================
- Hits 1368 1365 -3
Misses 116 116
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9ea8992 to
d316e9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this,
The view is forwarded to the parent block array, even when the
parentindicesof the view is a mix ofBlockandBlockRanges. On master, this works only if theparentindicesare allBlockRanges. This, usinglmul!instead ofLMulin the matrix-multiplication method, makes the following faster: