Skip to content

Please consider the following formatting changes to #12596 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
Closed

Please consider the following formatting changes to #12596 #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

Check failure on line 1 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specify task name only when it cannot be derived from the struct name. Only append to the default name.

Check failure on line 1 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Provide mandatory file documentation.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -11,7 +11,7 @@
///
/// \brief
/// \author Josué Martínez García, josuem@cern.ch
/// \file upcPhotonuclearAnalysisJMG.cxx

Check failure on line 14 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \brief is missing, incorrect or misplaced.

#include "PWGCF/Core/CorrelationContainer.h"
#include "PWGUD/Core/UPCPairCuts.h"
Expand All @@ -19,10 +19,10 @@
#include "PWGUD/DataModel/UDTables.h"

#include "Common/CCDB/EventSelectionParams.h"
#include "Common/Core/RecoDecay.h"
#include "Common/Core/TrackSelection.h"
#include "Common/Core/TrackSelectionDefaults.h"
#include "Common/Core/trackUtilities.h"
#include "Common/Core/RecoDecay.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/TrackSelectionTables.h"

Expand Down Expand Up @@ -98,7 +98,7 @@
static constexpr float CFGPairCutDefaults[1][5] = {{-1, -1, -1, -1, -1}};
constexpr float kThreeHalfPi = 1.5f * PI;

struct upcPhotonuclearAnalysisJMG {

Check failure on line 101 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/struct] 

Use UpperCamelCase for names of structs.

Produces<aod::TREE> tree;
HistogramRegistry histos{"histos", {}, OutputObjHandlingPolicy::AnalysisObject};
Expand Down Expand Up @@ -904,5 +904,5 @@

WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
return WorkflowSpec{adaptAnalysisTask<upcPhotonuclearAnalysisJMG>(cfgc, TaskName{"upcPhotonuclearAnalysisJMG"})};

Check failure on line 907 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specified task name upcPhotonuclearAnalysisJMG and the struct name upcPhotonuclearAnalysisJMG produce the same device name upc-photonuclear-analysis-j-m-g. TaskName is redundant.
}
Loading