Skip to content

Please consider the following formatting changes to #12596 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
Closed

Please consider the following formatting changes to #12596 #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

Check failure on line 1 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Provide mandatory file documentation.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -11,7 +11,7 @@
///
/// \brief
/// \author Josué Martínez García, josuem@cern.ch
/// \file upcPhotonuclearAnalysisJMG.cxx

Check failure on line 14 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \brief is missing, incorrect or misplaced.

#include "PWGCF/Core/CorrelationContainer.h"
#include "PWGUD/Core/UPCPairCuts.h"
Expand Down Expand Up @@ -96,7 +96,7 @@

static constexpr float CFGPairCutDefaults[1][5] = {{-1, -1, -1, -1, -1}};

struct upcPhotonuclearAnalysisJMG {

Check failure on line 99 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/struct] 

Use UpperCamelCase for names of structs.

Produces<aod::TREE> tree;
HistogramRegistry histos{"histos", {}, OutputObjHandlingPolicy::AnalysisObject};
Expand Down Expand Up @@ -447,11 +447,11 @@
continue;
}*/
float deltaPhi = phi(track1.px(), track1.py()) - phi(track2.px(), track2.py());
if (deltaPhi > 1.5f * PI) {

Check failure on line 450 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
deltaPhi -= TwoPI;

Check failure on line 451 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[two-pi-add-subtract] 

Use RecoDecay::constrainAngle to restrict angle to a given range.
}
if (deltaPhi < -PIHalf) {
deltaPhi += TwoPI;

Check failure on line 454 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[two-pi-add-subtract] 

Use RecoDecay::constrainAngle to restrict angle to a given range.
}
target->getPairHist()->Fill(CorrelationContainer::kCFStepReconstructed, eta(track1.px(), track1.py(), track1.pz()) - eta(track2.px(), track2.py(), track2.pz()), track2.pt(), track1.pt(), multiplicity, deltaPhi, posZ, 1.0);
}
Expand Down Expand Up @@ -506,7 +506,7 @@
{
auto hWeight = histos.get<TH3>(HIST("weightNUA"));
if (phi < 0)
phi += TwoPI;

Check failure on line 509 in PWGUD/Tasks/upcPhotonuclearAnalysisJMG.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[two-pi-add-subtract] 

Use RecoDecay::constrainAngle to restrict angle to a given range.
int iPhi = hWeight->GetZaxis()->FindBin(phi);
int iEta = hWeight->GetYaxis()->FindBin(eta);
int iVz = hWeight->GetXaxis()->FindBin(vz);
Expand Down Expand Up @@ -907,6 +907,5 @@
WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
return WorkflowSpec{
adaptAnalysisTask<upcPhotonuclearAnalysisJMG>(cfgc)
};
adaptAnalysisTask<upcPhotonuclearAnalysisJMG>(cfgc)};
}
Loading