Fix special characters in map seeds breaking file/folder creation #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Path.GetInvalidFileNameChars() instead of Path.GetInvalidPathChars() when escaping the seed string for subdirectory names. GetInvalidPathChars only returns control characters, missing characters like : < > " * ? | which are invalid in file/folder names on Windows. This fixes maps with seeds like "MountainPeople:3<3!!!!. failing to create output directories.
Apply Path.GetInvalidFileNameChars() escaping directly in CreateImageNameDateTime() and CreateImageNameNumbered() for the seed string and map name. This ensures special characters are stripped at the source, making the escaping explicit and consistent with the subdirectory escaping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Path.GetInvalidFileNameChars() instead of Path.GetInvalidPathChars() when escaping the seed string for subdirectory names. GetInvalidPathChars only returns control characters, missing characters like : < > " * ? | which are invalid in file/folder names on Windows.
This fixes maps with seeds like "MountainPeople:3<3!!!!. failing to create output directories. Special thanks to @JazzyRomance on the Progress Renderer Discord for finding this.