Fix syntax error when comment appears between index and table call #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a single-line comment appeared between an index suffix (like `.foo`)
and a table call argument (`{}`), the formatter would place the opening
parenthesis/brace on the same line as the comment, causing it to be
commented out and producing invalid Lua syntax.
For example, `foo.bar -- comment { x }` was being formatted as:
```
foo
.bar -- comment({
x,
})
```
Now the anonymous call is correctly placed on a new line when the
previous suffix has trailing single-line comments:
```
foo
.bar -- comment
({
x,
})
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a single-line comment appeared between an index suffix (like
.foo) and a table call argument ({}), the formatter would place the opening parenthesis/brace on the same line as the comment, causing it to be commented out and producing invalid Lua syntax.For example,
foo.bar -- comment { x }was being formatted as:Now the anonymous call is correctly placed on a new line when the previous suffix has trailing single-line comments:
Fixes #873