Codespell#129
Merged
Merged
Conversation
Owner
|
@lesserwhirls should i resolve conflicts and merge? |
* Set base workflow permission and only run on PRs * Only spellcheck the Readme
Collaborator
Author
|
I have been waffling on whether or not to keep this PR open, but I guess I am back to my thinking of probably good to have on public doc-like things (like the Readme). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon PR #81 with the following additions:
As mentioned on the previous PR, this only runs the spellcheck action if the readme (and in the future, docs) change, and fails the build if it detects issues so that we know. That won't prevent merging, but it would at least signal something to us.
Or, we could catch spelling errors in the editor as we encounter them. I'm fine either way.