-
Notifications
You must be signed in to change notification settings - Fork 0
PGLite, RSBuild, and Signals #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I think the first commit here (from long ago) introduces a bug. I see broken behavior when scrolling down a bit, (unloading the first page(s), then scrolling back up) (elements missing). |
public/ts/list_search.ts
Outdated
| preInitializationCallbacks | ||
| }); | ||
| registerOnLoad(() =>( { | ||
| updateViewModes() {; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the offending line that made me rm civet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this is the transpiled output)
Originally
Civet, PGLite, RSBuild, and SignalsCivet removed because a
;at the end of a last-line-in-fn caused the line to not get executed at all, crazy hard to track down bug.