Skip to content

Conversation

@arnokeesman
Copy link
Contributor

might've also snuck in a test, turns out the failing test I disabled in the last PR was never even tracked by git
CheckStyle should still be happy

have fun with this one SemanticDiff

so this was this test I was talking about with the update, turns out that thing was only on my machine and never on git, here goes anyway
@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 14, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/main/java/com/fibermc/essentialcommands/config/EssentialCommandsConfigSnapshot.java  61% smaller
  src/main/java/com/fibermc/essentialcommands/types/NamedLocationStorage.java  54% smaller
  src/main/java/com/fibermc/essentialcommands/types/WarpStorage.java  53% smaller
  src/main/java/com/fibermc/essentialcommands/WorldData.java  50% smaller
  src/main/java/com/fibermc/essentialcommands/commands/BedCommand.java  49% smaller
  src/main/java/com/fibermc/essentialcommands/ECPerms.java  49% smaller
  src/main/java/com/fibermc/essentialcommands/teleportation/PlayerTeleporter.java  43% smaller
  src/main/java/com/fibermc/essentialcommands/commands/RulesCommand.java  42% smaller
  src/main/java/com/fibermc/essentialcommands/util/EssentialsConvertor.java  41% smaller
  src/main/java/com/fibermc/essentialcommands/types/MinecraftLocation.java  40% smaller
  src/main/java/com/fibermc/essentialcommands/types/NbtSerializable.java  37% smaller
  src/main/java/com/fibermc/essentialcommands/commands/helpers/HeightFindingStrategy.java  34% smaller
  src/main/java/com/fibermc/essentialcommands/codec/Codecs.java  33% smaller
  src/main/java/com/fibermc/essentialcommands/text/ECText.java  26% smaller
  src/main/java/com/fibermc/essentialcommands/commands/TeleportAcceptCommand.java  25% smaller
  src/main/java/com/fibermc/essentialcommands/commands/TeleportDenyCommand.java  25% smaller
  src/main/java/com/fibermc/essentialcommands/screen/CraftingCommandScreenHandler.java  25% smaller
  src/main/java/com/fibermc/essentialcommands/screen/GrindstoneCommandScreenHandler.java  25% smaller
  src/main/java/com/fibermc/essentialcommands/playerdata/PlayerProfileFactory.java  24% smaller
  src/main/java/com/fibermc/essentialcommands/screen/AnvilCommandScreenHandler.java  23% smaller
  src/main/java/com/fibermc/essentialcommands/playerdata/PlayerProfile.java  22% smaller
  src/main/java/com/fibermc/essentialcommands/commands/suggestions/SuggestionListProvider.java  21% smaller
  src/main/java/com/fibermc/essentialcommands/teleportation/QueuedTeleport.java  20% smaller
  src/main/java/com/fibermc/essentialcommands/types/ProfileOptionFromContextSetter.java  20% smaller
  src/main/java/com/fibermc/essentialcommands/screen/StonecutterCommandScreenHandler.java  20% smaller
  src/main/java/com/fibermc/essentialcommands/util/PlayerUtilities.java  20% smaller
  src/main/java/com/fibermc/essentialcommands/commands/SleepCommand.java  19% smaller
  src/main/java/com/fibermc/essentialcommands/commands/suggestions/WarpSuggestion.java  18% smaller
  src/main/java/com/fibermc/essentialcommands/playerdata/PlayerData.java  17% smaller
  src/main/java/com/fibermc/essentialcommands/commands/suggestions/ListSuggestion.java  17% smaller
  src/main/java/com/fibermc/essentialcommands/commands/suggestions/TeleportResponseSuggestion.java  16% smaller
  src/main/java/com/fibermc/essentialcommands/commands/WarpDeleteCommand.java  15% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/TeleportCommandMixin.java  15% smaller
  src/main/java/com/fibermc/essentialcommands/commands/FlyCommand.java  14% smaller
  src/main/java/com/fibermc/essentialcommands/commands/SpawnSetCommand.java  14% smaller
  src/main/java/com/fibermc/essentialcommands/commands/WarpSetCommand.java  14% smaller
  src/main/java/com/fibermc/essentialcommands/commands/SpawnCommand.java  14% smaller
  src/main/java/com/fibermc/essentialcommands/commands/MotdCommand.java  13% smaller
  src/main/java/com/fibermc/essentialcommands/commands/ClearPlayerDataCommand.java  13% smaller
  src/main/java/com/fibermc/essentialcommands/commands/AfkCommand.java  13% smaller
  src/main/java/com/fibermc/essentialcommands/util/NicknameTextUtil.java  13% smaller
  src/main/java/com/fibermc/essentialcommands/commands/HomeSetCommand.java  12% smaller
  src/main/java/com/fibermc/essentialcommands/WorldDataManager.java  11% smaller
  ec-core/src/main/java/dev/jpcode/eccore/config/ConfigUtil.java  11% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/PrepareSpawnTaskMixin.java  10% smaller
  src/main/java/com/fibermc/essentialcommands/EssentialCommandRegistry.java  10% smaller
  src/main/java/com/fibermc/essentialcommands/commands/NicknameClearCommand.java  10% smaller
  src/main/java/com/fibermc/essentialcommands/commands/NicknameSetCommand.java  10% smaller
  src/main/java/com/fibermc/essentialcommands/util/FileUtil.java  10% smaller
  src/main/java/com/fibermc/essentialcommands/commands/helpers/HeightFinder.java  9% smaller
  src/main/java/com/fibermc/essentialcommands/commands/utility/DayCommand.java  9% smaller
  src/main/java/com/fibermc/essentialcommands/commands/utility/NightCommand.java  9% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/ServerPlayerMixin.java  9% smaller
  src/main/java/com/fibermc/essentialcommands/playerdata/PlayerDataManager.java  8% smaller
  src/main/java/com/fibermc/essentialcommands/commands/TeleportResponseCommand.java  8% smaller
  src/main/java/com/fibermc/essentialcommands/commands/ModInfoCommand.java  8% smaller
  src/main/java/com/fibermc/essentialcommands/events/PlayerDamageCallback.java  7% smaller
  src/main/java/com/fibermc/essentialcommands/events/PlayerDeathCallback.java  7% smaller
  src/main/java/com/fibermc/essentialcommands/types/ECPlaceholderApiCompat.java  7% smaller
  src/main/java/com/fibermc/essentialcommands/commands/bench/WorkbenchCommand.java  7% smaller
  src/main/java/com/fibermc/essentialcommands/commands/bench/StonecutterCommand.java  6% smaller
  src/main/java/com/fibermc/essentialcommands/commands/bench/GrindstoneCommand.java  6% smaller
  src/main/java/com/fibermc/essentialcommands/commands/utility/FeedCommand.java  6% smaller
  src/main/java/com/fibermc/essentialcommands/commands/bench/AnvilCommand.java  6% smaller
  src/main/java/com/fibermc/essentialcommands/commands/InvulnCommand.java  6% smaller
  src/main/java/com/fibermc/essentialcommands/commands/utility/RepairCommand.java  5% smaller
  src/main/java/com/fibermc/essentialcommands/commands/utility/GametimeCommand.java  5% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/PlayerMixin.java  4% smaller
  src/main/java/com/fibermc/essentialcommands/commands/RealNameCommand.java  4% smaller
  ec-core/src/main/java/dev/jpcode/eccore/util/TextUtil.java  4% smaller
  src/main/java/com/fibermc/essentialcommands/commands/bench/WastebinCommand.java  4% smaller
  src/main/java/com/fibermc/essentialcommands/types/NamedMinecraftLocation.java  4% smaller
  src/main/java/com/fibermc/essentialcommands/commands/FlySpeedCommand.java  3% smaller
  src/main/java/com/fibermc/essentialcommands/teleportation/QueuedPlayerTeleport.java  3% smaller
  src/main/java/com/fibermc/essentialcommands/commands/TeleportCancelCommand.java  3% smaller
  src/main/java/com/fibermc/essentialcommands/config/EssentialCommandsConfig.java  3% smaller
  src/main/java/com/fibermc/essentialcommands/events/PlayerRespawnCallback.java  3% smaller
  src/main/java/com/fibermc/essentialcommands/events/PlayerActCallback.java  3% smaller
  src/main/java/com/fibermc/essentialcommands/commands/utility/HealCommand.java  2% smaller
  src/main/java/com/fibermc/essentialcommands/commands/utility/ExtinguishCommand.java  2% smaller
  src/main/java/com/fibermc/essentialcommands/commands/helpers/FeedbackReceiver.java  2% smaller
  src/main/java/com/fibermc/essentialcommands/commands/BackCommand.java  1% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/PlayerListMixin.java  1% smaller
  src/main/java/com/fibermc/essentialcommands/commands/bench/SimpleScreenCommand.java  1% smaller
  build.gradle Unsupported file format
  ec-core/src/main/java/dev/jpcode/eccore/config/Config.java  0% smaller
  ec-core/src/main/java/dev/jpcode/eccore/util/StringToTextParser.java  0% smaller
  ec-core/src/main/java/dev/jpcode/eccore/util/TimeUtil.java  0% smaller
  ec-core/src/test/java/dev/jpcode/eccore/config/ConfigUtilTest.java  0% smaller
  ec-core/src/test/java/dev/jpcode/eccore/util/TextUtilTests.java  0% smaller
  gradle.properties Unsupported file format
  src/main/java/com/fibermc/essentialcommands/ECPlaceholderRegistry.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/CommandUtil.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/HomeCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/HomeDeleteCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/HomeOverwriteCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/HomeTeleportOtherCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/ListCommandFactory.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/ProfileCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/RandomTeleportCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/TeleportAskCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/TeleportAskHereCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/WarpTpCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/bench/EnderchestCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/helpers/IFeedbackReceiver.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/suggestions/NicknamePlayersSuggestion.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/suggestions/OfflinePlayerRepo.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/utility/NearCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/utility/SuicideCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/commands/utility/TopCommand.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/events/PlayerConnectCallback.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/events/PlayerLeaveCallback.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/ClientboundPlayerInfoUpdatePacketActionMixin.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/DimensionDataStorageInvoker.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/LivingEntityMixin.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/PlayerDataStorageMixin.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/ServerGamePacketListenerImplMixin.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/ServerPlayNetworkHandlerMixin.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/ServerScoreboardMixin.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/mixin/SleepStatusMixin.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/playerdata/IServerPlayerEntityData.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/playerdata/PlayerDataFactory.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/teleportation/QueuedLocationTeleport.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/teleportation/TeleportManager.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/teleportation/TeleportRequest.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/text/ChatConfirmationPrompt.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/text/ECTextImpl.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/text/PlayerECTextImpl.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/text/StringToTextParser.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/text/TextFormatType.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/types/IStyleProvider.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/types/WarpLocation.java  0% smaller
  src/main/java/com/fibermc/essentialcommands/util/EssentialsXParser.java  0% smaller
  src/main/resources/essential_commands.mixins.json  0% smaller
  src/test/java/com/fibermc/essentialcommands/ECTextTests.java  0% smaller

@John-Paul-R
Copy link
Owner

copying from discord

Alright, I see nothing here that sets off alarm bells. I'll run it locally shortly and will merge and deal with any fallout as it appears.
thanks again for doing that, was hardly on my radar

@John-Paul-R
Copy link
Owner

runs well for me, merging!

@John-Paul-R John-Paul-R merged commit ed48f2a into John-Paul-R:1.21.x Dec 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants