-
Notifications
You must be signed in to change notification settings - Fork 8
chore: update build dependencies and migrate to Gradle Version Catalog #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: update build dependencies and migrate to Gradle Version Catalog #53
Conversation
ec629f7 to
64dd3e6
Compare
gradle/libs.versions.toml
Outdated
|
|
||
| # Kotlin & Compose | ||
| junitJupiter = "6.0.1" | ||
| kotlin = "2.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the Kotlin version to 2.2.20 to maintain alignment with the latest IDEA .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Updated to 2.2.20 ✓
gradle/libs.versions.toml
Outdated
| kotlin = "2.3.0" | ||
| compose = "1.9.3" | ||
| mockk = "1.14.7" | ||
| skiko = "0.9.37.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this to 0.9.22.2 to align the Skiko and Compose versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Reverted to 0.9.22.2 ✓
- Migrated to Gradle Version Catalog (libs.versions.toml) - Updated Kotlin from 2.1.0 to 2.2.20 (IDEA compatibility) - Updated Gradle wrapper from 8.6 to 8.13.2 - Updated Android Gradle Plugin from 8.6.0 to 8.13.2 - Updated AndroidX Compose BOM to 2025.12.01 - Updated AndroidX Activity Compose to 1.12.2
2fdeb94 to
4fb5b34
Compare
| skiko = "0.9.22.2" | ||
|
|
||
| # Android | ||
| agp = "8.13.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use this version - gradle fails with the following error:
The project is using an incompatible version (AGP 8.13.2) of the Android Gradle plugin. Latest supported version is AGP 8.12.0
| java = "21" | ||
|
|
||
| # Kotlin & Compose | ||
| junitJupiter = "6.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use it in the project. Do we really need this?
| junitJupiter = "6.0.1" | ||
| kotlin = "2.2.20" | ||
| compose = "1.9.3" | ||
| mockk = "1.14.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use mockk. Lets remove it.
Summary
This PR updates the project's build dependencies to their latest stable versions and migrates dependency management to Gradle's Version Catalog pattern for improved maintainability.
Motivation
Modern dependency management using Version Catalogs provides:
Changes
Build Infrastructure
gradle/libs.versions.toml)Dependencies
Configuration
gradle.propertiesbuild.gradle.ktsfiles to reference version catalogsettings.gradle.ktsplugin managementTesting
✅ Verified clean build succeeds
✅ All Gradle tasks execute correctly
✅ No breaking changes to existing functionality
✅ Compatible with current Lets-Plot dependencies (4.12.1 / 4.8.2)
Compatibility
All existing Lets-Plot dependencies remain unchanged:
Checklist
Thank you for maintaining this excellent library! I hope this contribution helps keep the project's build infrastructure modern and maintainable. Please let me know if you'd like any changes to this PR.