Add support for retrieving Zoom Phone call queues#468
Open
MacgyverH wants to merge 8 commits intoJericho:developfrom
Open
Add support for retrieving Zoom Phone call queues#468MacgyverH wants to merge 8 commits intoJericho:developfrom
MacgyverH wants to merge 8 commits intoJericho:developfrom
Conversation
MacgyverH
commented
Jan 8, 2026
MacgyverH
commented
- Introduces models, interfaces, and resources for Zoom Phone call queues, including CallQueue and CallQueueMember entities.
- Adds ICallQueues and CallQueues resource classes with methods to retrieve call queue details, list call queues, and get queue members.
- Updates ZoomClient and IZoomClient to expose the new CallQueues resource.
- Registers new models in the JSON serializer context.
* Introduces models, interfaces, and resources for Zoom Phone call queues, including CallQueue and CallQueueMember entities. * Adds ICallQueues and CallQueues resource classes with methods to retrieve call queue details, list call queues, and get queue members. * Updates ZoomClient and IZoomClient to expose the new CallQueues resource. * Registers new models in the JSON serializer context.
Moved CallQueuePhoneNumber and CallQueueSite to separate files and added XML documentation to CallQueueMember, CallQueuePhoneNumber, and CallQueueSite classes for improved clarity and maintainability.
Jericho
requested changes
Jan 9, 2026
Owner
Jericho
left a comment
Jericho
left a comment
There was a problem hiding this comment.
Thank you for your contribution. A few very minor changes and also, let's debate/discuss whether these methods really deserve their own resource of whether they would fit in the existing 'Phone' resource.
ivan-pavlik
reviewed
Jan 22, 2026
Jericho
requested changes
Jan 22, 2026
Owner
Jericho
left a comment
Jericho
left a comment
There was a problem hiding this comment.
Delete this model class and use the existing Site model
Author
|
Hey, sorry for the delays, I got pulled into some other projects, I'll work on these adjustments and get them submitted soon! |
- Use the existing Site type for CallQueue.Site - Update ICallQueues and CallQueues parameters and docs from snake_case (cost_center, site_id) to camelCase (costCenter, siteId)
Remove separate CallQueues/ICallQueues resources and integrate call-queue endpoints into the existing Phone API.
Author
|
Requested changes have been made. |
- Introduce a new CallQueueStatus enum (active/inactive) to represent call queue state and add it to the JSON serializer context. - Remove the ICallQueues API surface from IZoomClient and the CallQueues initialization from ZoomClient, reflecting removal of the CallQueues resource from the client implementation. - Removed no longer needed CallQueueSite references in ZoomNetJsonSerializerContex
Author
|
Cleaned up the PR based on your review. |
- Change the CallQueue.Status property from string to CallQueueStatus enum.
- Introduce CallQueueNumberSource enum (internal/external) with EnumMember values and replace CallQueuePhoneNumber.Source string with this enum for stronger typing. - Register the new enum type and its array in ZoomNetJsonSerializerContext to enable proper JSON (de)serialization.
ivan-pavlik
reviewed
Feb 4, 2026
|
|
||
| #region Call Queues | ||
| /// <inheritdoc/> | ||
| public Task<CallQueue> GetCallQueueAsync(string callQueueId, CancellationToken cancellationToken = default) |
Contributor
There was a problem hiding this comment.
It seems that (according to the specification) this endpoint provides more details about the requested call queue. So we can define CallQueueDetails inherited from CallQueue and add more properties there.
Author
There was a problem hiding this comment.
I'll compare and add the missing properties to the new class as suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.