Clean up TopologyBuilder interface#495
Merged
Merged
Conversation
snake_case originally indicated that a method was supposed to be internal. However, people don't like that, so we are moving away from doing that. Either way, JArrow is also gradually becoming part of the interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My latest GPU offloading work is using custom topologies, which were never made part of the "public-facing" interface. This PR significantly improves the code quality of JTopologyBuilder, making it fit for public consumption, and laying the groundwork for defining custom topologies in the wiring file.
integration_testsbinary for end-to-end testing, e.g. of custom topologies. Eventually a number of longer-running tests will be moved from unit-tests to here.