Skip to content

[codex] Fix auth callback timeout and today filtering#24

Merged
JeelyWu merged 2 commits into
masterfrom
fix/auth-callback-test-timeout
May 16, 2026
Merged

[codex] Fix auth callback timeout and today filtering#24
JeelyWu merged 2 commits into
masterfrom
fix/auth-callback-test-timeout

Conversation

@JeelyWu
Copy link
Copy Markdown
Owner

@JeelyWu JeelyWu commented May 16, 2026

Summary

  • Keep the auth callback test listener open until the login flow consumes it, avoiding callback timing races.
  • Make the top-level today command request open tasks explicitly, matching task ls --today behavior.
  • Add regression coverage for TaskApp.Today() so completed tasks are not requested or returned by the today shortcut.

Root Cause

TaskApp.Today() called List with only Today: true. That left the API request without an open-status filter, unlike task ls --today, which defaults to open tasks. In live E2E testing this caused the top-level today command to miss a test task that task ls --today returned.

Validation

  • go test ./...
  • make smoke
  • Live E2E against dida365 with isolated codex-e2e-20260516215706 projects/tasks, including project/task/quick/today/config/habit/focus coverage; created test data was deleted and cleanup was verified.

@JeelyWu JeelyWu closed this May 16, 2026
@JeelyWu JeelyWu deleted the fix/auth-callback-test-timeout branch May 16, 2026 14:24
@JeelyWu JeelyWu restored the fix/auth-callback-test-timeout branch May 16, 2026 14:39
@JeelyWu JeelyWu reopened this May 16, 2026
@JeelyWu JeelyWu marked this pull request as ready for review May 16, 2026 14:40
@JeelyWu JeelyWu merged commit d418f10 into master May 16, 2026
2 checks passed
@JeelyWu JeelyWu deleted the fix/auth-callback-test-timeout branch May 16, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant