No longer debounce componentWillReceiveProps #106

[ovidiuch]

Fixes #106

[alexandro81]

Hi @skidding, just wanted to know if you are plan to check this in soon, since IMHO it's not a good idea to debounce a lifecycle event.

[ovidiuch]

@alexandro81 it's not up to me since I don't have write nor publish rights on this project. See this thread for now.

[alexandro81]

Got it, thanks!

[alexandro81]

@JedWatson is there any blocker for this? It would be nice to have the fixed checked-in, unless you think there's something wrong in the PR?

[rickhanlonii]

Bump

[rocktavious]

Double Bump!

[danez]

//cc @JedWatson

[besh]

@JedWatson If this gets merged, can it be part of a minor release? All our team needed recently was fixing the 15.5 deprecation warnings but that was bundled with the v1 release with a lot of other changes.

[budiantotan]

bump!

[inoas]

This is another PR aiming at the same issue #122

[christopherdro]

Confirming this fixes #106.

/cc @JedWatson

[scniro]

react-codemirror2. Help me build it however we want. Let's move on - we've been waiting months. Why are you all still holding out?

[inoas]

Maybe his subscription here is off, so I felt free and asked him directly: https://twitter.com/In0as/status/896357219473780737

[lin-credible]

🌷 👍 🌹

[windhamwong]

Tested out and this works perfectly.

[devonbl]

@JedWatson bump <3<3<3

[scniro]

@devonbl react-codemirror2 <3<3<3

[inoas]

So the thing is:

1. Can @JedWatson review and merge; Alternatively give @skidding merge privileges?

2. If not 1. - Can we agree on one fork and move the community over there and continue over there? Also please deprecate react-codemirror?

3. Candidates

• https://github.com/scniro/react-codemirror2
• https://github.com/skidding/react-codemirror/tree/106-fix-update author seems to be ok to use react-codemirror2 in future (if it works for him) - Code mirror value doesn't update with state change in v1.0.0 #106 (comment)

[inoas]

Edit: Please try https://github.com/scniro/react-codemirror2 instead.
That fork is maintained, available via npm and gathering stars.