Remove LLVM 20 limitation#485
Merged
JeanPhilippeKernel merged 1 commit intoJeanPhilippeKernel:developfrom Mar 31, 2026
Merged
Conversation
JeanPhilippeKernel
requested changes
Jan 16, 2026
MathewBensonCode
force-pushed
the
update-llvm
branch
from
fa70173 to
3e0a9fc
Compare
MathewBensonCode
force-pushed
the
update-llvm
branch
from
3e0a9fc to
8ad3db9
Compare
MathewBensonCode
force-pushed
the
update-llvm
branch
from
8ad3db9 to
2582656
Compare
MathewBensonCode
force-pushed
the
update-llvm
branch
from
2582656 to
698bbb1
Compare
- Isolate code that has changed in behaviour since version 20 and use
clang-format off comments to ignore
- CoroutineScheduler.h and VulkanDevice.h for
operator bool()
- VulkanDevice.cpp for re-aligned declarations
- RenderPasses.cpp for re-aligned function signature
- update CI workflows for all OSs to use version 22
MathewBensonCode
force-pushed
the
update-llvm
branch
from
698bbb1 to
c006273
Compare
Contributor
Author
|
Updated this to support llvm version 22, which is now the current stable version. I also all the CIs including the clang-format steps to use clang-format version 22. I isolated the few areas which have issues in the newer versions by excluding them using This means that we should be able to work with any version from 20 upto 22, and even older(but haven't tested those) |
Owner
|
the spreading usage of |
JeanPhilippeKernel
added
area-window
JeanPhilippeKernel
approved these changes
Mar 31, 2026
JeanPhilippeKernel
merged commit e07ed95
into
JeanPhilippeKernel:develop
21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #484