Skip to content

Conversation

@JeXTCy
Copy link
Owner

@JeXTCy JeXTCy commented Nov 22, 2025

Summary

  • add a standalone AI Arranger single-page app with arranger and ABC editor views
  • implement genre/mood based arrangement generation, ABC export, MIDI drag-and-drop, and playback utilities

Testing

  • not run (not requested)

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +574 to +577
getMidiDataUri(sections, bpm, key, name) {
const track = this.buildTrack(sections, bpm, key);
const writer = new MidiWriter.Writer(track);
return `audio/midi:${name}.mid:${writer.dataUri().split(',')[1]}`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Provide valid data URI for drag-and-drop MIDI

getMidiDataUri strips the data:audio/midi;base64, prefix from writer.dataUri(), returning audio/midi:<name>.mid:<base64> instead. That string is written to the DownloadURL dataTransfer type when you drag a timeline card, but without a real URL scheme browsers ignore the drop, so the advertised DAW drag-and-drop MIDI export never yields a file. Keep the full data URI (including the scheme and base64 prefix) so the drop target receives a valid MIDI payload.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant