Skip to content

Refactor tests for clarity and maintainability #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedrinhoeu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor tests for clarity and maintainability #4816

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42e898f
Update largeWriteTest
pedrinhoeu Jul 17, 2025
6cdcc8c
Update testObjectVerification
pedrinhoeu Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,22 +212,22 @@
out.writeObject(null,TClass1.class);

//Test failure
for (Object o : new Object[]{new TClass2("abc",2),Calendar.getInstance(), Lists.newArrayList()}) {
for (Object o : new Object[]{new TClass2("abc",2), Calendar.getInstance(), new java.util.ArrayList<>()}) {

Check notice on line 215 in janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java#L215 

Unnecessary use of fully qualified name 'java.util.ArrayList' due to existing import 'java.util.ArrayList'
try {
out.writeObjectNotNull(o);
fail();
fail("Expected an exception but none was thrown");
} catch (Exception ignored) {

}
}

ReadBuffer b = out.getStaticBuffer().asReadBuffer();
assertEquals(t1, serialize.readClassAndObject(b));
assertNull(serialize.readClassAndObject(b));
assertEquals(t1, serialize.readObject(b, TClass1.class));
assertNull(serialize.readObject(b, TClass1.class));
assertEquals(t1, serialize.readClassAndObject(b), "The first object read does not match the expected TClass1 instance");
assertNull(serialize.readClassAndObject(b), "Expected null for the second read but found a non-null value");
assertEquals(t1, serialize.readObject(b, TClass1.class), "The third object read does not match the expected TClass1 instance");
assertNull(serialize.readObject(b, TClass1.class), "Expected null for the fourth read but found a non-null value");

assertFalse(b.hasRemaining());
assertFalse(b.hasRemaining(), "Buffer should have no remaining data after all reads");
}


Expand All @@ -245,8 +245,8 @@
out.writeObjectNotNull(str.toString());
ReadBuffer b = out.getStaticBuffer().asReadBuffer();
if (printStats) log.debug(bufferStats(b));
assertEquals(str.toString(), serialize.readObjectNotNull(b, String.class));
assertFalse(b.hasRemaining());
assertEquals(str.toString(), serialize.readObjectNotNull(b, String.class), "Serialized string does not match the original string");
assertFalse(b.hasRemaining(), "The buffer has remaining data after reading");
}

@Test
Expand Down
Loading