Skip to content

fix: prepopulate with all current values in Neuroglancer short link editing dialog#311

Merged
allison-truhlar merged 3 commits intomainfrom
prepopulate-ng-link-editing-dialog
Feb 13, 2026
Merged

fix: prepopulate with all current values in Neuroglancer short link editing dialog#311
allison-truhlar merged 3 commits intomainfrom
prepopulate-ng-link-editing-dialog

Conversation

@allison-truhlar
Copy link
Collaborator

Clickup id: 86aex4z5n

This PR prepopulates the Neuroglancer short link editing dialog with the current Neuroglancer URL and title in "URL mode", and with the current JSON state, base URL, and title in "State mode". To make it more straightforward to populate the dialog, the response model for Neuroglancer short links was updated to include the stored Neuroglancer state object and the base URL. This allows the Neuroglancer URL to be reconstructed without needing to request the state from the backend using the state_url. To make copying/pasting or deleting the current Neuroglancer URL easier for the user, when the editing dialog is first opened, the full Neuroglancer URL is automatically selected.

The PR also adds a component test using React Testing Library to check these initial states.

@krokicki

Copy link
Member

@neomorphic neomorphic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@allison-truhlar allison-truhlar merged commit 135c8d9 into main Feb 13, 2026
7 checks passed
@allison-truhlar allison-truhlar deleted the prepopulate-ng-link-editing-dialog branch February 13, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants