feat(registry): add .npmrc config support#316
Draft
evaliyev wants to merge 3 commits intoJamieMason:mainfrom
Draft
feat(registry): add .npmrc config support#316evaliyev wants to merge 3 commits intoJamieMason:mainfrom
evaliyev wants to merge 3 commits intoJamieMason:mainfrom
Conversation
def7ca5 to
d41fd88
Compare
Contributor
Author
|
@JamieMason Please take a look. |
Owner
|
Thanks a lot @evaliyev, this new crate is a huge help. It'll take some time to work through this PR but here are some thoughts so far:
Hope this makes sense, I can take a look myself when I get time but if you can have a go at these refactors before then, that would be great. And then finally, with the crate having been created in such a short space of time, I'd just ask that you add as many E2E or integration tests as you can, ideally including some on Windows as well as Linux if you can. Thanks again for this, a massive step forward on an issue I was struggling with. |
Contributor
Author
|
Thank you @JamieMason for the review! Your comments really make sense and I will try to address them in the next couple of days. |
9ef74b4 to
9cb0a6f
Compare
9cb0a6f to
f79b789
Compare
c974534 to
ee9a9e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npmrc-config-rsto resolve registry URLs from.npmrcfiles@company:registry=https://private.example.com)npm.jsr.iofor@jsr/*packages when not explicitly configuredWhat I checked
cargo test- 276 tests pass.npmrc