Clarify content-encoding comment applies to all toolbar injections #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
The comment now accurately states that empty content-encoding is returned for all successful toolbar injections, not just gzip-decompressed responses. This addresses feedback that the original comment was misleading. Co-authored-by: JacobCoffee <45884264+JacobCoffee@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on gzip-compressed responses
Clarify content-encoding comment applies to all toolbar injections
Dec 28, 2025
JacobCoffee
approved these changes
Dec 28, 2025
JacobCoffee
merged commit f867495
into
fix/gzip-compression-injection
0 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment at the return statement of
_inject_toolbarincorrectly implied that empty content-encoding was only returned for gzip-decompressed responses. In reality, it's returned for all successful toolbar injections.Changes
middleware.py:524-527: Clarified that empty content-encoding is returned for all successful toolbar injections, regardless of whether the input was originally compressedThe function always returns uncompressed UTF-8 with empty content-encoding after toolbar injection, whether or not the original response was gzip-compressed.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.