[WIP] Fix gzip handling in toolbar injection based on feedback #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Add comprehensive test coverage for edge cases in gzip handling: - Invalid gzip data with content-encoding: gzip header - Valid gzip data that fails UTF-8 decoding after decompression - Case-insensitive content-encoding header matching (GZIP, GzIp) Co-authored-by: JacobCoffee <45884264+JacobCoffee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Successfully added comprehensive test coverage for all three error handling scenarios in the gzip decompression logic as requested in the review feedback. All 24 integration tests pass, including the 3 new tests.
Tests Added
test_invalid_gzip_data_with_gzip_header- Verifies graceful fallback when response claims to be gzipped but contains invalid gzip datatest_gzip_decompressed_data_fails_utf8_decoding- Verifies handling when valid gzip data decompresses but contains non-UTF-8 bytestest_gzip_header_case_insensitive- Verifies case-insensitive handling of content-encoding header valuesCode Review Note
The automated code review identified a potential optimization in the implementation where re-compressing already-decompressed data could be avoided by storing the original body. However, this is an implementation detail separate from the test coverage request and can be addressed in a follow-up if needed.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.