Add 15 non-standard BibLaTeX entry types with .withType() method #14534

shubhamk0205 · 2025-12-06T01:20:56Z

Adds 15 non-standard BibLaTeX entry types (Artwork, Audio, Bibnote, Commentary, Image, Jurisdiction, Legislation, Legal, Letter, Movie, Music, Performance, Review, Standard, Video) that are hard-coded and only available in BibLaTeX mode. These types are displayed in a dedicated "Non-standard Types" group in the New Entry dialog and in the context menu. The implementation introduces a .withType() method to BibEntryType that allows creating type variants with the same field definitions, enabling all 15 types to be implemented as one-liners based on the MISC entry type.

Steps to test

Prerequisites: Ensure the library is in BibLaTeX mode (Library → Library Properties → General → Library mode = "biblatex").

New Entry dialog: Press Ctrl+N → Scroll to "Non-standard types" section → Verify all 15 types are visible with tooltips → Click any type to create an entry → Verify correct type is set.
Context menu: Right-click an entry → "Change entry type" → "Non-standard Types" → Verify all 15 types listed → Select a type → Verify entry type changes → Confirm no duplicates in main menu.
BibTeX mode: Switch to BibTeX mode → Open New Entry dialog → Verify "Non-standard types" section is hidden → Right-click entry → Verify "Non-standard Types" submenu is not present.
Persistence: Create entry with non-standard type → Add fields → Save library → Close and reopen → Verify entry type persists.

Screenshots

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

Siedlerchr · 2025-12-06T15:41:38Z

jabgui/src/main/java/org/jabref/gui/newentry/NewEntryView.java

+            // Non-standard Types (BibLaTeX only) - these use the @misc driver in standard bibliography styles
+            // Descriptions are taken from subsection 2.1.3 of the biblatex package documentation.
+            case Artwork ->
+                    Localization.lang("Works of the visual arts such as paintings, sculpture, and installations.");


All of these need do be added to en.properties

Siedlerchr · 2025-12-06T15:42:00Z

jablib/src/main/resources/l10n/JabRef_en.properties

 Plain\ citation\ parsing\ may\ generate\ inappropriate\ results.=Plain citation parsing may generate inappropriate results.
 Recommended\ types=Recommended types
+Non-standard\ types=Non-standard types
+Non-standard\ Types=Non-standard Types


Duplicate here and add all the other new descriptions

Siedlerchr · 2025-12-06T15:42:15Z

jablib/src/main/java/org/jabref/model/database/KeyCollisionException.java

 public class KeyCollisionException extends RuntimeException {

-    private String id;
+    private @Nullable String id;


Do not modify this class

Siedlerchr · 2025-12-06T15:43:32Z

jablib/src/main/java/org/jabref/model/entry/types/BiblatexEntryTypeDefinitions.java

 */
 public class BiblatexEntryTypeDefinitions {

+    static final BibEntryType MISC = new BibEntryTypeBuilder()


Please move to the old position after article, makes it easer to review the changes and I don't think there are some

Siedlerchr · 2025-12-06T15:46:28Z

jablib/src/main/java/org/jabref/model/entry/BibEntryType.java

+     * @param newType The new EntryType to use
+     * @return A new BibEntryType instance with the new type but same field definitions
+     */
+    public BibEntryType withType(@NonNull EntryType newType) {


This is unnecesary, we already hava. constructor

Siedlerchr

See comments
Also you are missing tests

* New translations jabref_en.properties (French) * New translations jabref_en.properties (Spanish) * New translations jabref_en.properties (Danish) * New translations jabref_en.properties (German) * New translations jabref_en.properties (Greek) * New translations jabref_en.properties (Italian) * New translations jabref_en.properties (Japanese) * New translations jabref_en.properties (Korean) * New translations jabref_en.properties (Dutch) * New translations jabref_en.properties (Norwegian) * New translations jabref_en.properties (Polish) * New translations jabref_en.properties (Portuguese) * New translations jabref_en.properties (Russian) * New translations jabref_en.properties (Swedish) * New translations jabref_en.properties (Turkish) * New translations jabref_en.properties (Chinese Simplified) * New translations jabref_en.properties (Vietnamese) * New translations jabref_en.properties (Portuguese, Brazilian) * New translations jabref_en.properties (Indonesian) * New translations jabref_en.properties (Tagalog)

jabgui/src/main/java/org/jabref/gui/menus/ChangeEntryTypeMenu.java

koppor · 2025-12-07T20:13:54Z

jablib/src/main/java/org/jabref/model/entry/types/BiblatexEntryTypeDefinitions.java

+    private static final BibEntryType MISC = new BibEntryTypeBuilder()
+            .withType(StandardEntryType.Misc)
+            .withRequiredFields(new OrFields(StandardField.AUTHOR, StandardField.EDITOR), StandardField.TITLE, StandardField.DATE)
+            .withImportantFields(
+                    StandardField.SUBTITLE, StandardField.TITLEADDON, StandardField.HOWPUBLISHED, StandardField.LOCATION, StandardField.DOI,
+                    StandardField.EPRINT, StandardField.EPRINTCLASS, StandardField.EPRINTTYPE, StandardField.URL, StandardField.URLDATE)
+            .withDetailFields(StandardField.LANGUAGE,
+                    StandardField.TYPE, StandardField.VERSION, StandardField.NOTE, StandardField.ORGANIZATION,
+                    StandardField.PAGETOTAL, StandardField.ADDENDUM, StandardField.PUBSTATE)
+            .build();
+
    private static final BibEntryType BOOK = new BibEntryTypeBuilder()


We like alphabetical ordering - please keep the position

understood . on it

…java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

Siedlerchr · 2025-12-08T20:37:36Z

jablib/src/main/java/org/jabref/model/entry/types/StandardEntryType.java

-    Dataset("Dataset");
+    Dataset("Dataset"),
+    // Non-standard Types (BibLaTeX only)
+    Artwork("Artwork"),


These non standard types must be moved to it's own class, e.g. see BiblatexSoftwareEntryType or BiblatexApaEntryType

calixtus · 2025-12-08T20:41:14Z

jablib/src/main/java/org/jabref/model/entry/types/StandardEntryType.java

+    Dataset("Dataset"),
+    // Non-standard Types (BibLaTeX only)
+    Artwork("Artwork"),
+    Audio("Audio"),
+    Bibnote("Bibnote"),
+    Commentary("Commentary"),
+    Image("Image"),
+    Jurisdiction("Jurisdiction"),
+    Legislation("Legislation"),
+    Legal("Legal"),
+    Letter("Letter"),
+    Movie("Movie"),
+    Music("Music"),
+    Performance("Performance"),
+    Review("Review"),
+    Standard("Standard"),
+    Video("Video");


This is contradictory. Add non-standard entry types to Enum StandardEntryTypes.
I will not agree to this.

If it is absolutely necessary, then it must be a separate types class such as ieeeEntryTypes, if at all.
@JabRef/developers

DevCall decision: We move forward with supporting these types hardcoded - in a separate class. As outlined by SiedlerChr.

* Junie try 1 * Refine test * Fix casing

…the connected files

calixtus · 2025-12-08T21:39:37Z

jablib/src/main/java/org/jabref/logic/net/ProxyPreferences.java

+    // Creates object with default preference values
+    private ProxyPreferences() {
+        this(
+                false,      // useProxy: Whether to enable proxy usage
+                "",         // proxyHostname: The hostname of proxy
+                "80",       // proxyPort: Port number on which the proxy is listening
+                false,      // useAuthentication: Whether proxy authentication should be enabled
+                "",         // proxyUsername: Username for proxy authentication (if enabled)
+                "",         // proxyPassword: Password for proxy authentication (if enabled)
+                false       // persistPassword: Whether the proxy password should be saved/persisted
+        );
+    }
+
+    public static ProxyPreferences getDefault() {
+        return new ProxyPreferences();
+    }
+
+    public void setAll(ProxyPreferences preferences) {
+        this.useProxy.set(preferences.shouldUseProxy());
+        this.hostname.set(preferences.getHostname());
+        this.port.set(preferences.getPort());
+        this.useAuthentication.set(preferences.shouldUseAuthentication());
+        this.username.set(preferences.getUsername());
+        this.password.set(preferences.getPassword());
+        this.persistPassword.set(preferences.shouldPersistPassword());
+    }
+


This looks like an artifact from another PR...

this file is not actually modified in this PR , it is identical to main , the commit appears in the history because i think it was merged from the main , but there are no actual changes to that file

@calixtus if u still want this to be removed from the history i will make a new clean pr with the same changes

No, do not create another PR. Just fix / cleanup your branch and push it. the GitHub PR will be updated automatically.

shubhamk0205 added 2 commits December 6, 2025 06:29

Add 15 non-standard BibLaTeX entry types with .withType() method

03b48c6

updated ChangeLog.md

a27a967

github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 6, 2025

shubhamk0205 added 5 commits December 6, 2025 06:57

fixed formatting issue

7d50ef8

fixed Formatting

0a7edfe

fixed Checkstyle's DeclarationOrder

2877bff

fix checkstyle errors

31c6a90

fixed Key Collision error

17049e0

Siedlerchr reviewed Dec 6, 2025

View reviewed changes

Siedlerchr requested changes Dec 6, 2025

View reviewed changes

Siedlerchr and others added 5 commits December 7, 2025 03:54

Revise JavaDoc links in README.md (JabRef#14533)

5b004f0

applied given changes

77b86ad

fixed formatting

59247bd

fixed formatting

317234e

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 7, 2025

shubhamk0205 requested a review from Siedlerchr December 7, 2025 11:18

Merge branch 'main' into fix-for-issue-12963

8a38484

koppor requested changes Dec 7, 2025

View reviewed changes

github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 7, 2025

Update jabgui/src/main/java/org/jabref/gui/menus/ChangeEntryTypeMenu.…

65f4fd3

…java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 7, 2025

fixed alphabatical ordering

202afdd

shubhamk0205 requested a review from koppor December 7, 2025 23:26

Merge branch 'main' into fix-for-issue-12963

4b5fd02

D-Prasanth-Kumar approved these changes Dec 8, 2025

View reviewed changes

Siedlerchr reviewed Dec 8, 2025

View reviewed changes

calixtus requested changes Dec 8, 2025

View reviewed changes

calixtus added the status: devcall label Dec 8, 2025

github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 8, 2025

koppor removed the status: devcall label Dec 8, 2025

koppor and others added 6 commits December 9, 2025 02:47

Fix link

73feddf

Proxy Preference reset (JabRef#14554)

430b6b9

Fix typos (JabRef#14552)

bc36bdb

Add LlmPlainCitationParserTest (JabRef#14553)

2f12ee7

* Junie try 1 * Refine test * Fix casing

updated ChangeLog.md

e422716

moved the non-standard types to their own own enum class and updated …

aa3a428

…the connected files

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 8, 2025

calixtus reviewed Dec 8, 2025

View reviewed changes

koppor added the status: changes-required Pull requests that are not yet complete label Dec 8, 2025

shubhamk0205 requested a review from calixtus December 9, 2025 19:39

Uh oh!

Add 15 non-standard BibLaTeX entry types with .withType() method #14534

Are you sure you want to change the base?

Add 15 non-standard BibLaTeX entry types with .withType() method #14534

Conversation

shubhamk0205 commented Dec 6, 2025 • edited by calixtus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Screenshots

Mandatory checks

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubhamk0205 Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shubhamk0205 commented Dec 6, 2025 •

edited by calixtus

Loading

Siedlerchr Dec 6, 2025 •

edited

Loading

Siedlerchr Dec 6, 2025 •

edited

Loading

shubhamk0205 Dec 7, 2025 •

edited

Loading

Siedlerchr Dec 8, 2025 •

edited

Loading