-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Implement reset for MainTablePreferences #14523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Annabel Wang <annabelwyn11@gmail.com>
|
Hey @nbelwang! 👋 Thank you for contributing to JabRef! We have automated checks in place, based on which you will soon get feedback if any of them are failing. After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. Please re-check our AI Usage Policy to ensure that your pull request is in line with it. It also contains links to our contribution guide in case of any other doubts related to our contribution workflow. |
Signed-off-by: Annabel Wang <annabelwyn11@gmail.com>
jabgui/src/main/java/org/jabref/gui/maintable/MainTablePreferences.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Annabel Wang <annabelwyn11@gmail.com>
Signed-off-by: Annabel Wang <annabelwyn11@gmail.com>
|
I'm a bit confused on how to resolve my failing checks, I ran rewriteRun which passed, but there were no changes for me to commit. I'm not sure what my other failing tests mean either. |
|
CI says following error This is not about your change, but some infrastructure issue. |
Closes #14413
Hello! This is my first contribution. I followed the instructions in #14400 and implemented a private default constructor, getDefault, and setAll method in MainTablePreferences, and added them into JabRefGuiPreferences. I put empty lists for ColumnPreferences in the default constructor because ColumnPreferences doesn't have the getDefault() or setAll() yet, I hope that is correct.
Steps to test
I followed the instructions from the developer documentation and ran the final build system check, which passed, but I was unsure how else to test this as I am not familiar with importing or exporting preferences into JabRef.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)