Skip to content

Conversation

@nbelwang
Copy link

@nbelwang nbelwang commented Dec 5, 2025

Closes #14413

Hello! This is my first contribution. I followed the instructions in #14400 and implemented a private default constructor, getDefault, and setAll method in MainTablePreferences, and added them into JabRefGuiPreferences. I put empty lists for ColumnPreferences in the default constructor because ColumnPreferences doesn't have the getDefault() or setAll() yet, I hope that is correct.

Steps to test

I followed the instructions from the developer documentation and ran the final build system check, which passed, but I was unsure how else to test this as I am not familiar with importing or exporting preferences into JabRef.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

Signed-off-by: Annabel Wang <annabelwyn11@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Hey @nbelwang! 👋

Thank you for contributing to JabRef!

We have automated checks in place, based on which you will soon get feedback if any of them are failing.

After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs.

Please re-check our AI Usage Policy to ensure that your pull request is in line with it. It also contains links to our contribution guide in case of any other doubts related to our contribution workflow.

@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 5, 2025
@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 5, 2025
@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 6, 2025
@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 6, 2025
koppor
koppor previously approved these changes Dec 8, 2025
@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 8, 2025
@nbelwang
Copy link
Author

nbelwang commented Dec 9, 2025

I'm a bit confused on how to resolve my failing checks, I ran rewriteRun which passed, but there were no changes for me to commit. I'm not sure what my other failing tests mean either.

@koppor
Copy link
Member

koppor commented Dec 9, 2025

CI says following error

* What went wrong:
Could not determine the dependencies of task ':jablib:compileJava'.
> Failed to query the value of extension 'errorprone' property 'enabled'.
   > Failed to calculate the value of task ':jablib:compileJava' property 'javaCompiler'.
      > Cannot find a Java installation on your machine (Linux 6.11.0-1018-azure amd64) matching: {languageVersion=24, vendor=Amazon Corretto, implementation=vendor-specific, nativeImageCapable=false}. No matching toolchain could be found in the configured toolchain download repositories.

This is not about your change, but some infrastructure issue.

@koppor koppor mentioned this pull request Dec 9, 2025
1 task
@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable resetting of MainTablePreferences

2 participants