refactor: 여행 회고 및 여행 리포트 기능에서 완료된 미션 수를 학습 로그 개수로 리팩토링(#96) #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: MissionQueryRepository, MissionQueryRepositoryAdapter에서 countCompletedMissionsByTripId 메서드 삭제 * feat: MissionQueryService에서 countCompletedMissionsByTripId 메서드 삭제 * feat: StudyLogQueryRepository, StudyLogQueryRepositoryAdapter에 countStudyLogsByTripId 메서드 추가 * feat: StudyLogQueryService에 getStudyLogCountByTripId 메서드 추가 * refactor: TripReportFacade.getTripRetrospect()에서 completedMissionCount -> studyLogCount 비즈니스 로직 개선 * refactor: TripReport에서 completedMissionCount -> studyLogCount 필드 이름 변경 * refactor: TripReportFactory에서 completedMissionCount -> studyLogCount 매개변수 로직 수정 * refactor: CreateTripReportRequest에서 completedMissionCount -> studyLogCount 변경 * refactor: TripRetrospectSummary, LoadTripRetrospectDetailResponse에서 completedMissionCount -> studyLogCount 변경 * refactor: TripReportInfo, LoadTripReportDetailResponse에서 completedMissionCount -> studyLogCount 변경 * chore: V7__rename_completed_mission_count_to_study_log_count.sql 스크립트 추가 * test: MissionQueryServiceTest에서 CountCompletedMissionsByTripId 단위 테스트 삭제 * test: StudyLogQueryServiceTest에 GetStudyLogCountByTripId 단위 테스트 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 내용 및 특이사항
✅ 완료된 미션 수를 학습 로그 개수로 리팩토링
MissionQueryRepository,MissionQueryRepositoryAdapter에서 countCompletedMissionsByTripId 메서드 삭제MissionQueryService에서 countCompletedMissionsByTripId 메서드 삭제TripReport에서 completedMissionCount -> studyLogCount 필드 이름 변경TripReportFactory에서 completedMissionCount -> studyLogCount 매개변수 로직 수정StudyLogQueryRepository,StudyLogQueryRepositoryAdapter에 countStudyLogsByTripId 메서드 추가StudyLogQueryService에 getStudyLogCountByTripId 메서드 추가TripReportFacade.getTripRetrospect()에서 completedMissionCount -> studyLogCount 비즈니스 로직 개선✅ Application DTO 수정
TripRetrospectSummary,TripReportInfo에서 completedMissionCount -> studyLogCount 변경✅ Presentation DTO 수정
CreateTripReportRequest에서 completedMissionCount -> studyLogCount 변경LoadTripRetrospectDetailResponse,LoadTripReportDetailResponse에서 completedMissionCount -> studyLogCount 변경✅ Flyway 스크립트 추가
V7__rename_completed_mission_count_to_study_log_count.sql스크립트 추가✅ 테스트
MissionQueryServiceTest에서CountCompletedMissionsByTripId단위 테스트 삭제StudyLogQueryServiceTest에GetStudyLogCountByTripId단위 테스트 추가🌱 관련 이슈
🔍 참고사항(선택)
📚 기타(선택)