design: 후기 작성 화면 UI 개선#192
Open
she0108 wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Walkthrough
Changes태그 렌더링 레이아웃 단순화
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MintPansy
approved these changes
May 30, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@features/review/components/review-write-content.tsx`:
- Line 180: The Tailwind class uses invalid arbitrary value syntax: replace the
token "focus-visible:ring-(--color-border-primary)" with the correct arbitrary
value form "focus-visible:ring-[var(--color-border-primary)]" in the affected
components (e.g., update the class string in ReviewWriteContent component where
the class contains 'text-body-sm ... focus-visible:ring-(--color-border-primary)
...' and do the same fix in the Stepper component class containing the same
invalid token) so Tailwind applies the focus ring correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 349fbe9e-a4dc-4343-878b-ae2bc3638b61
📒 Files selected for processing (1)
features/review/components/review-write-content.tsx
| aria-pressed={selected} | ||
| disabled={!selected && selectedTagIds.size >= MAX_TAGS} | ||
| className={cn( | ||
| 'text-body-sm inline-flex h-[33px] max-w-full shrink-0 items-center justify-center rounded-full border px-2.5 font-normal transition-colors outline-none focus-visible:ring-2 focus-visible:ring-(--color-border-primary) focus-visible:ring-offset-1', |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Tailwind 빌드 및 CSS 출력 확인
# Check if Tailwind config exists and grep for custom color variables
fd -t f 'tailwind.config' --exec cat {} \; | head -100
# Search for CSS variable definitions in the codebase
rg --type=css -n -C2 '--color-border-primary'
# Check if this exact class pattern exists elsewhere in the codebase
rg -n 'ring-\(--' --glob '*.{ts,tsx,js,jsx}'Repository: JECT-Study/Sossbar-4th-Client
Length of output: 1070
Tailwind 포커스 링 클래스 문법 오류 수정 필요
focus-visible:ring-(--color-border-primary)는 Tailwind 임의값 문법(ring-[...])이 아니라 포커스 링이 적용되지 않을 수 있습니다. 동일 잘못된 패턴이 features/review/components/review-write-content.tsx(180)와 shared/components/stepper.tsx(90)에 존재합니다.
🔧 제안 수정안
- 'text-body-sm inline-flex h-[33px] max-w-full shrink-0 items-center justify-center rounded-full border px-2.5 font-normal transition-colors outline-none focus-visible:ring-2 focus-visible:ring-(--color-border-primary) focus-visible:ring-offset-1',
+ 'text-body-sm inline-flex h-[33px] max-w-full shrink-0 items-center justify-center rounded-full border px-2.5 font-normal transition-colors outline-none focus-visible:ring-2 focus-visible:ring-[var(--color-border-primary)] focus-visible:ring-offset-1',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| 'text-body-sm inline-flex h-[33px] max-w-full shrink-0 items-center justify-center rounded-full border px-2.5 font-normal transition-colors outline-none focus-visible:ring-2 focus-visible:ring-(--color-border-primary) focus-visible:ring-offset-1', | |
| 'text-body-sm inline-flex h-[33px] max-w-full shrink-0 items-center justify-center rounded-full border px-2.5 font-normal transition-colors outline-none focus-visible:ring-2 focus-visible:ring-[var(--color-border-primary)] focus-visible:ring-offset-1', |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@features/review/components/review-write-content.tsx` at line 180, The
Tailwind class uses invalid arbitrary value syntax: replace the token
"focus-visible:ring-(--color-border-primary)" with the correct arbitrary value
form "focus-visible:ring-[var(--color-border-primary)]" in the affected
components (e.g., update the class string in ReviewWriteContent component where
the class contains 'text-body-sm ... focus-visible:ring-(--color-border-primary)
...' and do the same fix in the Stepper component class containing the same
invalid token) so Tailwind applies the focus ring correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 개요
UI상 피그마와 다른 부분들을 수정했습니다.
🔗 관련 이슈
🛠️ 변경 사항 (Checklist)
✅ 아래 내용을 한 번 더 점검해 주세요
1. 의도와 가독성 (Naming & Readability)
2. 타입과 논리 (Type Safety & Logic)
any사용을 지양하고, 모든 함수의 반환 타입을 명시했나요?null/undefined), 에러가 발생할 경우를 처리했나요?3. 코드 다이어트 (Clean-up)
console.log나 사용하지 않는import를 모두 지웠나요?4. 지속 가능성 (Sustainability)
README업데이트가 필요한가요?💭 회고 (Optional)
Summary by CodeRabbit
릴리스 노트