Updates from macOS testing

[mathomp4]

Description

This has updates needed in my testing on macOS.

One change that is "generic" to many is the change to configs/common/modules_lmod.yaml and configs/common/modules_tcl.yaml, e.g.,:

      python:
        environment:
          set:
            'Python_ROOT_DIR': '{prefix}'
            'Python3_ROOT_DIR': '{prefix}'

The reason is because CMake's FindPython and FindPython3 look at Python_ROOT_DIR and Python3_ROOT_DIR as hints, but spack only provides python_ROOT_DIR...and CMake is case-sensitive.

This also has a change to allow both older and newer FMS as GEOS (at present) only works with FMS 2024.

Dependencies

• Updates from macOS testing spack-packages#53

Issues addressed

Closes #1983
Closes #1982
Closes #1984

Applications affected

None

Systems affected

None

Testing

• CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
  • GitHub actions CI tests pass
  • GitHub actions CI tests do not pass (provide explanation)
  • GitHub actions CI tests skipped (provide explanation if necessary)
• New tests added: List and describe any new tests added to GitHub actions
  • ...
• Additional testing: Add information on any additional tests conducted
  • ...

Checklist

• This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
• These changes have been tested on the affected systems and applications.
• All dependency PRs/issues have been resolved and this PR can be merged.
• All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged @mathomp4 do you want to add NAG to the compiler matrix, or is it too early?

[climbfuji]

@mathomp4 Can you resolve the conflicts, please? It would be nice to test this + JCSDA/spack-packages#53 in CI. Thanks!

[mathomp4]

@mathomp4 Can you resolve the conflicts, please? It would be nice to test this + JCSDA/spack-packages#53 in CI. Thanks!

@climbfuji I think I did this right? I had to lean on some GPT to help because it was a new git error/warning I'd never seen before (since it involved a submodule, etc)

[climbfuji]

@mathomp4 Can you resolve the conflicts, please? It would be nice to test this + JCSDA/spack-packages#53 in CI. Thanks!

@climbfuji I think I did this right? I had to lean on some GPT to help because it was a new git error/warning I'd never seen before (since it involved a submodule, etc)

Yep, that looks good, thanks very much. It's churning ...

[climbfuji]

This is taking a while! The two intel builds worked so far. I am wondering if we need to update an openmpi version for the GNU build in CI. I'll look closer tomorrow.

[climbfuji]

@mathomp4 The GNU CI build worked, see https://github.com/JCSDA/spack-stack/actions/runs/25456010122/job/74685548751?pr=2003.

I am going to merge the spack-packages PR that goes with this PR. When you update the submodule pointer and revert any .gitmodules changes, can you please also bump up the OpenMPI version in

spack-stack/.github/workflows/ubuntu-ci-x86_64-gnu.yaml

Line 105 in 4eb2ee9

spack config add "packages:mpi:require:['openmpi@5.0.8']"

and

spack-stack/.github/workflows/ubuntu-ci-x86_64-gnu.yaml

Line 228 in 4eb2ee9

module load stack-openmpi/5.0.8

?

[climbfuji]

New spack-packages hash is JCSDA/spack-packages@522153d

[mathomp4]

@climbfuji Done and done, I believe.