Skip to content

Conversation

@climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 16, 2025

Description

release/2.0: Update batch_install.sh - workaround for ParallelWorks: no NRL GitHub access (yet), turn off adp variant.

Dependencies

None

Issues addressed

Add any issues here that this PR closes or is related to. Use "Resolves" or "Closes" to automatically close issues when the PR is merged. Using "Working towards" or "Related to" for other cases.

Applications affected

None

Systems affected

ParallelWorks

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added: List and describe any new tests added to GitHub actions
    • ...
  • Additional testing: Add information on any additional tests conducted
    • Tested on ParallelWorks

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation on readthedocs are included in this PR
    • For site config updates, check in particular doc/source/PreConfiguredSites.rst and doc/source/MaintainersSection.rst
  • All necessary updates to the spack-stack wiki will be made when this PR is merged

Copy link
Collaborator

@stefangary stefangary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an elegant way to turn off the adp variant by changing any +adp to ~adp in the package.py.

@climbfuji climbfuji merged commit 57d03d8 into release/2.0 Dec 17, 2025
7 checks passed
@climbfuji climbfuji deleted the feature/pw_no_nrl_enterprise_github branch December 17, 2025 14:58
@github-project-automation github-project-automation bot moved this from In Progress to Done in spack-stack-2.0.x (2025 Q4) Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants