-
Notifications
You must be signed in to change notification settings - Fork 2
add test data for crtm reconstructed radiance operator. #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Some of the added files are quite big (74Mb). We try to keep the repo as small as possible and we would prefer files of size under 1Mb. Would it be possible for you to reduce the files size by subsampling the data? Thanks. |
|
@mikecooke77 This is the PR with the large size of testing data to be trimmed. Please let us know if you find anything regarding similar tests for RTTOV. |
I think there is a similarly large file for RTTOV in https://github.com/JCSDA-internal/ufo-data/tree/feature/cmatrix_crtm/testinput_tier_1/resources/auxillary e.g. mtgirs_cmatrix_and_bias I think both of these files should be stored on git lfs not git. Therefore I would suggest adding both to: https://github.com/JCSDA-internal/ufo-data/blob/feature/cmatrix_crtm/.gitattributes You can just add the full filename. Then you will want to renormalize the repo e.g. git add --renormalize . |
|
@mikecooke77 agree with putting the file in @karpob will do this tomorrow if you don't beat us to it. @rajichidamb added you as a reviewer |
|
@rajichidamb thanks! I was literally just about to look at this. |
Please feel free to fix if I missed anything. |
Looks good to me! |
Description
PR associated with ufo pull request for supporting test data for ufo feature/cmatrix_crtm
needed for ufo PR: https://github.com/JCSDA-internal/ufo/pull/3885