[pr-staging-deploy]: improve reliability of staging deploy lifecycle#417
Merged
[pr-staging-deploy]: improve reliability of staging deploy lifecycle#417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No intermediate comments: bot no longer posts "Deploying..." or "Redeploying..." —
only one final comment is created: either "Deployed" (with links) or "Deploy failed" (with logs)
No comment editing: all final comments use
forceNewComment: trueto avoidunstable comment IDs and edit race conditions
Fork PR support: deploy now uses the fork's
clone_urlfrom the webhook payload,so Sliplane clones the correct repository when a PR comes from a fork
synchronizefallback: if new commits are pushed to a PR but no services exist yet(first push, services were deleted, or rapid consecutive pushes), falls back to a fresh
deploy instead of reporting "Redeploy failed: 0 service(s)"
Startup scan: on app restart, pending Sliplane deployments are detected and
re-enqueued automatically — PR comments are updated to their final state after redeploy
Hard timeout: polling loop stops after 30 minutes with a clear "Deploy timed out" comment
instead of running indefinitely
PR-number-based service naming: services are now named
ivy-staging-docs-{prNumber}instead of using the sanitized branch name, making lookup deterministic across all events