Skip to content

Conversation

@kostamax27
Copy link

No description provided.

@IvanCraft623
Copy link
Owner

Now that i see these functions I think it shouldn't even call the event on these cases, since these are totally invalid arguments

@kostamax27
Copy link
Author

Now that i see these functions I think it shouldn't even call the event on these cases, since these are totally invalid arguments

It would be useful to know exactly when the data changes.
For example, setRank and other methods could return a Promise or a \Generator, using await-generator. This would make it possible to explicitly track when updates are completed and handle them in a more predictable way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants