Skip to content

Conversation

@kostamax27
Copy link

@UnknownNull
Copy link

If the player has many permissions he will lag

https://github.com/pmmp/PocketMine-MP/blob/04494e845c8ec9ae174604b6dde6c1cc6c22953a/src/network/mcpe/NetworkSession.php#L290-L295

After reviewing and testing your changes, I realized that your changes apparently had no effect on fixing the lag.
If I'm wrong, convince me.

@kostamax27
Copy link
Author

If the player has many permissions he will lag
https://github.com/pmmp/PocketMine-MP/blob/04494e845c8ec9ae174604b6dde6c1cc6c22953a/src/network/mcpe/NetworkSession.php#L290-L295

After reviewing and testing your changes, I realized that your changes apparently had no effect on fixing the lag. If I'm wrong, convince me.

After calling removeAttachment or addAttachment, the following code is executed for the player every time:

https://github.com/pmmp/PocketMine-MP/blob/37668da8a6c2ad2ce12b284bad60e993931fcfe4/src/network/mcpe/NetworkSession.php#L299-L304

Now imagine the following scenario:
the player’s privilege has more than 10 permissions, and the server has a large number of registered commands.

Due to the frequent execution of
https://github.com/pmmp/PocketMine-MP/blob/37668da8a6c2ad2ce12b284bad60e993931fcfe4/src/network/mcpe/NetworkSession.php#L299-L304
the player starts experiencing lag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants