refactor: clean up force-unwraps and enable lint ratchet

.githooks/pre-commit

@@ -24,7 +24,7 @@ echo "🔍 Running SwiftLint on staged files…"
 # Lint only the staged files (faster than full project)
 echo "$staged_swift_files" | while read -r file; do
   if [[ -f "$file" ]]; then
-    swiftlint lint --quiet --strict --use-script-input-files <<< "$file" || {
+    swiftlint lint --quiet --strict "$file" || {
       echo ""
       echo "❌ SwiftLint failed. Fix the issues above, then re-stage and commit."
       echo "   To bypass (NOT recommended), use: git commit --no-verify"

.swiftlint.yml

@@ -90,7 +90,7 @@ force_cast:
 force_try:
   severity: error                    # error: same
 force_unwrapping:
-  severity: warning                  # warning today → bump to error after cleanup PR
+  severity: error
 
 # Custom project rules
 custom_rules:

Savely/Managers/CameraManager.swift

@@ -87,10 +87,11 @@ class CameraManager: NSObject, ObservableObject {
     }
 
     func setPreviewLayer(to view: UIView) {
-        previewLayer = AVCaptureVideoPreviewLayer(session: session)
-        previewLayer?.videoGravity = .resizeAspectFill
-        previewLayer?.frame = view.bounds
-        view.layer.insertSublayer(previewLayer!, at: 0)
+        let layer = AVCaptureVideoPreviewLayer(session: session)
+        layer.videoGravity = .resizeAspectFill
+        layer.frame = view.bounds
+        previewLayer = layer
+        view.layer.insertSublayer(layer, at: 0)
     }
 
     func capturePhoto() {

Savely/Models/ExpenseModel.swift

@@ -29,7 +29,11 @@ extension ExpenseModel {
         print("Fetching expenses from \(startDate) to \(endDate)")
 
         // Precompute adjusted end date
-        let adjustedEndDate = Calendar.current.startOfDay(for: Calendar.current.date(byAdding: .day, value: 1, to: endDate)!)
+        guard let nextDay = Calendar.current.date(byAdding: .day, value: 1, to: endDate) else {
+            print("Error computing adjusted end date for expense fetch")
+            return []
+        }
+        let adjustedEndDate = Calendar.current.startOfDay(for: nextDay)
 
         let fetchDescriptor = FetchDescriptor<ExpenseModel>(
             predicate: #Predicate {

Savely/Models/IncomeModel.swift

@@ -29,7 +29,11 @@ extension IncomeModel {
         print("Fetching incomes from \(startDate) to \(endDate)")
 
         // Precompute adjusted end date
-        let adjustedEndDate = Calendar.current.startOfDay(for: Calendar.current.date(byAdding: .day, value: 1, to: endDate)!)
+        guard let nextDay = Calendar.current.date(byAdding: .day, value: 1, to: endDate) else {
+            print("Error computing adjusted end date for income fetch")
+            return []
+        }
+        let adjustedEndDate = Calendar.current.startOfDay(for: nextDay)
 
         let fetchDescriptor = FetchDescriptor<IncomeModel>(
             predicate: #Predicate {

Savely/Utilities/OpenAIClient.swift

@@ -23,8 +23,11 @@ class OpenAIClient {
     }
 
     func fetchTip(prompt: String) async -> String? {
-        let url = URL(string: "https://api.openai.com/v1/chat/completions")!
-
+        guard let url = URL(string: "https://api.openai.com/v1/chat/completions") else {
+            return nil
+        }
+
+
         // Construir el mensaje para el modelo
         let messages = [
             OpenAIChatMessage(role: "system", content: "Eres un asistente financiero."),

Savely/Utilities/SignInWithAppleHelper.swift

@@ -181,7 +181,7 @@
 
     @MainActor
     private func topViewController(controller: UIViewController? = nil) -> UIViewController? {
         let controller = controller ?? UIApplication.shared.keyWindow?.rootViewController
 
         if let navigationController = controller as? UINavigationController {
             return topViewController(controller: navigationController.visibleViewController)
@@ -231,8 +231,8 @@
     }
 }
 
 extension UIViewController: ASAuthorizationControllerPresentationContextProviding {
     public func presentationAnchor(for controller: ASAuthorizationController) -> ASPresentationAnchor {
-        return self.view.window!
+        return self.view.window ?? ASPresentationAnchor()
     }
 }

Savely/ViewModels/Dashboard/ReportsViewModel.swift

@@ -18,7 +18,7 @@
 
     var modelContext: ModelContext? {
         didSet {
             guard let modelContext = modelContext else { return }
             fetchReportData()
         }
     }
@@ -74,7 +74,8 @@
         print("Fetching weekly incomes...")
 
         let adjustedStartDate = Calendar.current.startOfDay(for: startDate)
-        let adjustedEndDate = Calendar.current.startOfDay(for: Calendar.current.date(byAdding: .day, value: 1, to: endDate)!)
+        guard let nextDay = Calendar.current.date(byAdding: .day, value: 1, to: endDate) else { return [] }
+        let adjustedEndDate = Calendar.current.startOfDay(for: nextDay)
 
         let fetchDescriptor = FetchDescriptor<IncomeModel>(
             predicate: #Predicate {
@@ -89,7 +90,8 @@
         print("Fetching weekly expenses...")
 
         let adjustedStartDate = Calendar.current.startOfDay(for: startDate)
-        let adjustedEndDate = Calendar.current.startOfDay(for: Calendar.current.date(byAdding: .day, value: 1, to: endDate)!)
+        guard let nextDay = Calendar.current.date(byAdding: .day, value: 1, to: endDate) else { return [] }
+        let adjustedEndDate = Calendar.current.startOfDay(for: nextDay)
 
         let fetchDescriptor = FetchDescriptor<ExpenseModel>(
             predicate: #Predicate {

Savely/ViewModels/ProfileTab/ProfileViewModel.swift

@@ -122,7 +122,8 @@ class ProfileViewModel: ObservableObject {
     private func fetchWeeklyIncome(from startDate: Date, to endDate: Date, in context: ModelContext) async throws -> [IncomeModel] {
         print("fetchWeeklyIncome: Fetching incomes...")
         let adjustedStartDate = Calendar.current.startOfDay(for: startDate)
-        let adjustedEndDate = Calendar.current.startOfDay(for: Calendar.current.date(byAdding: .day, value: 1, to: endDate)!)
+        guard let nextDay = Calendar.current.date(byAdding: .day, value: 1, to: endDate) else { return [] }
+        let adjustedEndDate = Calendar.current.startOfDay(for: nextDay)
 
         let fetchDescriptor = FetchDescriptor<IncomeModel>(
             predicate: #Predicate {
@@ -139,7 +140,8 @@ class ProfileViewModel: ObservableObject {
     private func fetchWeeklyExpenses(from startDate: Date, to endDate: Date, in context: ModelContext) async throws -> [ExpenseModel] {
         print("fetchWeeklyExpenses: Fetching expenses...")
         let adjustedStartDate = Calendar.current.startOfDay(for: startDate)
-        let adjustedEndDate = Calendar.current.startOfDay(for: Calendar.current.date(byAdding: .day, value: 1, to: endDate)!)
+        guard let nextDay = Calendar.current.date(byAdding: .day, value: 1, to: endDate) else { return [] }
+        let adjustedEndDate = Calendar.current.startOfDay(for: nextDay)
 
         let fetchDescriptor = FetchDescriptor<ExpenseModel>(
             predicate: #Predicate {

Savely/Views/MainNavigationView.swift

@@ -656,7 +656,7 @@ struct WarmQuickDepositView: View {
 
             Button(action: saveDeposit) {
                 let goalName = selectedGoal.map { $0.name.components(separatedBy: ",").first ?? $0.name }
-                Text(goalName != nil ? "Add $\(Int(selectedPreset)) to \(goalName!)" : "Select a goal")
+                Text(goalName.map { "Add $\(Int(selectedPreset)) to \($0)" } ?? "Select a goal")
                     .font(.system(size: 15, weight: .semibold)).foregroundStyle(.white)
                     .frame(maxWidth: .infinity).frame(height: 50)
                     .background(selectedGoal != nil ? Color.warmGreen : Color.warmInkMuted)