Skip to content

[SDK-232] add startEmbeddedImpression and pauseEmbeddedImpression methods to ReactIterableAPI #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lposen wants to merge 1 commit into
base: loren/embedded/SDK-235-ios-add-ability-to-sync-and-get-messages
Choose a base branch
from
Open

[SDK-232] add startEmbeddedImpression and pauseEmbeddedImpression methods to ReactIterableAPI #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ios/RNIterableAPI/RNIterableAPI.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,14 @@ - (void)getEmbeddedMessages:(NSArray *_Nullable)placementIds
[_swiftAPI getEmbeddedMessages:placementIds resolver:resolve rejecter:reject];
}

- (void)startEmbeddedImpression:(NSString *)messageId placementId:(double)placementId {
[_swiftAPI startEmbeddedImpression:messageId placementId:placementId];
}

- (void)pauseEmbeddedImpression:(NSString *)messageId {
[_swiftAPI pauseEmbeddedImpression:messageId];
}

- (void)wakeApp {
// Placeholder function -- this method is only used in Android
}
Expand Down Expand Up @@ -541,6 +549,14 @@ - (void)wakeApp {
[_swiftAPI getEmbeddedMessages:placementIds resolver:resolve rejecter:reject];
}

RCT_EXPORT_METHOD(startEmbeddedImpression : (NSString *)messageId placementId : (double)placementId) {
[_swiftAPI startEmbeddedImpression:messageId placementId:placementId];
}

RCT_EXPORT_METHOD(pauseEmbeddedImpression : (NSString *)messageId) {
[_swiftAPI pauseEmbeddedImpression:messageId];
}

RCT_EXPORT_METHOD(wakeApp) {
// Placeholder function -- this method is only used in Android
}
Expand Down
12 changes: 12 additions & 0 deletions ios/RNIterableAPI/ReactIterableAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,18 @@ import React
resolver(messages.map { $0.toDict() })
}

@objc(startEmbeddedImpression:placementId:)
public func startEmbeddedImpression(messageId: String, placementId: Double) {
ITBInfo()
EmbeddedSessionManager.shared.startImpression(messageId: messageId, placementId: placementId)
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placementId parameter is passed as Double directly to the EmbeddedSessionManager, but based on the Android implementation and the existing getEmbeddedMessages method in this file (line 527), placementId should be converted to Int before passing to the native SDK. The Android bridge explicitly casts double to int, and getEmbeddedMessages uses placementId.intValue when calling the SDK. Consider converting the Double to Int: Int(placementId) or verify that the EmbeddedSessionManager.startImpression method accepts Double.

Suggested change
EmbeddedSessionManager.shared.startImpression(messageId: messageId, placementId: placementId)
EmbeddedSessionManager.shared.startImpression(messageId: messageId, placementId: Int(placementId))

Copilot uses AI. Check for mistakes.
}

@objc(pauseEmbeddedImpression:)
public func pauseEmbeddedImpression(messageId: String) {
ITBInfo()
EmbeddedSessionManager.shared.pauseImpression(messageId: messageId)
}

// MARK: Private
private var shouldEmit = false
private let _methodQueue = DispatchQueue(label: String(describing: ReactIterableAPI.self))
Expand Down