-
Notifications
You must be signed in to change notification settings - Fork 42
[SDK-235] Add ability to sync and get messages #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: loren/embedded/SDK-240-ios-add-ability-to-start-and-end-a-session
Are you sure you want to change the base?
Conversation
…ng embedded messages
… and improve message retrieval
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the ability to sync embedded messages and retrieve embedded messages with optional placement ID filtering for the iOS platform. The Android implementation already exists in the codebase.
Changes:
- Added iOS native implementation for
syncEmbeddedMessages()andgetEmbeddedMessages()methods - Added serialization support for
IterableEmbeddedMessageto convert to dictionary format - Simplified the example app usage to pass placement IDs directly instead of chaining promises
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ios/RNIterableAPI/Serialization.swift | Adds toDict() extension for IterableEmbeddedMessage to serialize messages for React Native |
| ios/RNIterableAPI/ReactIterableAPI.swift | Implements syncEmbeddedMessages() and getEmbeddedMessages() methods with placement ID filtering |
| ios/RNIterableAPI/RNIterableAPI.mm | Exports the new methods for both new and legacy React Native architectures |
| example/src/components/Embedded/Embedded.tsx | Simplifies the getEmbeddedMessages callback to accept placement IDs directly as a parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

🔹 JIRA Ticket(s) if any
✏️ Description
Testing
Setup
yarn installyarn installbundle exec pod installwatchman watch-del-allyarn start --reset-cacheopen ReactNativeSdkExample.xcworkspace