Skip to content

Conversation

@ashert-hsueh
Copy link
Contributor

Changes include:

  • Show user avatar in usermenu after successful login (same as on main page)
  • Adjust dropdown z-index to ensure it appears above main content

@vercel
Copy link

vercel bot commented Oct 14, 2025

@ashert-hsueh is attempting to deploy a commit to the longsizhuo's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
involutionhell-github-io Ready Ready Preview Comment Oct 14, 2025 1:57pm
website-preview Ready Ready Preview Comment Oct 14, 2025 1:57pm

@Mira190
Copy link
Contributor

Mira190 commented Oct 14, 2025

preview点击主页登录会报错,大佬再看看能优化吗
image

@longsizhuo
Copy link
Member

是因为web-preview用的是另外一个域名,而我们的GitHub注册返回的是我们正式域名,所以我在prod域名下的preview运行看一下

@longsizhuo longsizhuo requested a review from Copilot October 14, 2025 13:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the login button logic in the user menu by implementing conditional rendering to show either a user avatar menu or sign-in button based on authentication state. The changes also improve the dropdown's visual layering.

  • Converted baseOptions() to async function to fetch user session data
  • Added conditional rendering to show UserMenu for authenticated users or SignInButton for unauthenticated users
  • Improved dropdown z-index to ensure proper layering above main content

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
lib/layout.shared.tsx Added session authentication and conditional user menu rendering
auth.ts Removed empty line for code cleanup
app/docs/layout.tsx Updated to handle async baseOptions function call
app/components/UserMenu.tsx Added z-index styling to dropdown for proper layering

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@longsizhuo longsizhuo merged commit e570deb into InvolutionHell:main Oct 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants