Potential fix for code scanning alert no. 3: Incomplete multi-character sanitization #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/InvolutionHell/involutionhell.github.io/security/code-scanning/3
To fix this problem, we need to ensure all HTML/MDX tags are thoroughly removed, including cases where consecutive characters produce nested or re-emerging unsafe constructs after initial replacement (such as
<script>and similar patterns). The ideal approach is to repeatedly apply the tag-removal regular expression until no more tags are detected, so that constructs like<<script>>are reduced to an empty string or harmless content.Specifically, in the
extractTextFromMDXfunction in app/docs/[...slug]/page.tsx, we should change the.replace(/<[^>]+>/g, "")on line 24 to a loop that repeatedly applies it until no more changes occur. No new libraries are required if we use this approach.Required changes:
.replace()call for HTML/MDX tags with a loop that continues replacing as long as matches are found.extractTextFromMDX.Suggested fixes powered by Copilot Autofix. Review carefully before merging.