-
Notifications
You must be signed in to change notification settings - Fork 0
OCTO-367 remove usage of em-synchrony active record adapter #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ttstarck
merged 15 commits into
v0.x-master
from
OCTO-367_remove_usage_of_em_synchrony_adapter
Aug 21, 2025
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e746524
stop using em-synchrony as base adapter
ttstarck 7a43092
remove rails 6 gemfile
ttstarck aa7bdb4
add logger
ttstarck afb90ba
only run on push
ttstarck 7a4e928
remove transaction manager override
ttstarck 7a4775b
remove transaction manager override
ttstarck 66ddd3c
new pre-release version
ttstarck 1cb9f43
remove unused initialize
ttstarck 10faec8
allow rails 7.1
ttstarck a77c8fc
add back the initialize method
ttstarck f95ac62
Revert "add back the initialize method"
ttstarck 8f552bc
only include specific code for version 7.0 / 7.1
ttstarck 7e5c777
bump to 0.4
ttstarck e64f48a
remove commented out code
ttstarck 621d4a9
prepare for full release
ttstarck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,10 +7,9 @@ gemspec | |
|
|
||
| gem 'appraisal' | ||
| gem 'appraisal-matrix' | ||
| gem 'coveralls', require: false | ||
| gem 'mysql2', '~> 0.5' | ||
| gem 'nokogiri' | ||
| gem 'pry' | ||
| gem 'pry-byebug' | ||
| gem 'rake' | ||
| gem 'rspec' | ||
|
Comment on lines
-10
to
-16
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am consistently getting random segfaults issues with coveralls and rspec mocks. Rspec 3.12 seems to be a little better for the segfaults but I think this is an issue with EventMachine as well... Also |
||
| gem 'rspec', '< 3.13' | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull_requestwas seemingly causing two builds to run at the same time. Removing it fixed the issue.