Skip to content

Remove Gemfiles for Rails 6 and less (TECH-17268_bump_appraisals) #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttstarck merged 4 commits into from
Feb 20, 2025
Merged

Remove Gemfiles for Rails 6 and less (TECH-17268_bump_appraisals) #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8bfb993
Remove old Rails < 7 gemfiles
ttstarck Feb 19, 2025
3be76ab
remove tmp file
ttstarck Feb 19, 2025
a14a95b
fix build.yml
ttstarck Feb 19, 2025
d7ea928
limit sqlite for rails 7.0
ttstarck Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [3.1, 3.2, 3.3]
ruby: [3.1, 3.2, 3.3, 3.4]
gemfile:
- gemfiles/rails_6_0.gemfile
- gemfiles/rails_6_1.gemfile
- gemfiles/rails_7_0.gemfile
- gemfiles/rails_7_1.gemfile
- gemfiles/rails_7_2.gemfile
- gemfiles/rails_8_0.gemfile
exclude:
- ruby: 3.1
gemfile: gemfiles/rails_8_0.gemfile
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
steps:
Expand Down
8 changes: 6 additions & 2 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

require 'appraisal/matrix'

appraisal_matrix(rails: "6.0") do
gem 'sqlite3', '~> 1.4'
appraisal_matrix(rails: "7.0") do |rails:|
if rails <= "7.0"
gem 'sqlite3', '~> 1.4'
else
gem 'sqlite3'
end
end
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
GEM
remote: https://rubygems.org/
specs:
actioncable (7.1.3.4)

Check failure on line 10 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L10 

          actionpack
          Warning Message: https://github.com/rails/rails/security/advisories/GHSA-x76w-6vjr-8xgj
          CVE:             CVE-2024-41128
          Severity:

Check failure on line 10 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L10 

          actionpack
          Warning Message: https://github.com/rails/rails/security/advisories/GHSA-vfg9-r3fq-jvx4
          CVE:             CVE-2024-47887
          Severity:

Check failure on line 10 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L10 

          actionpack
          Warning Message: https://github.com/rails/rails/security/advisories/GHSA-vfm5-rmrh-j26v
          CVE:             CVE-2024-54133
          Severity:
actionpack (= 7.1.3.4)
activesupport (= 7.1.3.4)
nio4r (~> 2.0)
Expand All @@ -19,10 +19,10 @@
activerecord (= 7.1.3.4)
activestorage (= 7.1.3.4)
activesupport (= 7.1.3.4)
mail (>= 2.7.1)

Check failure on line 22 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L22 

          net-imap
          Warning Message: https://github.com/ruby/net-imap/security/advisories/GHSA-7fc5-f82f-cx69
          CVE:             CVE-2025-25186
          Severity:        medium
net-imap
net-pop
net-smtp

Check failure on line 25 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L25 

          actionmailer
          Warning Message: https://github.com/rails/rails/security/advisories/GHSA-h47h-mwp9-c6q6
          CVE:             CVE-2024-47889
          Severity:
actionmailer (7.1.3.4)
actionpack (= 7.1.3.4)
actionview (= 7.1.3.4)
Expand All @@ -35,14 +35,14 @@
rails-dom-testing (~> 2.2)
actionpack (7.1.3.4)
actionview (= 7.1.3.4)
activesupport (= 7.1.3.4)

Check failure on line 38 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L38 

          nokogiri
          Warning Message: https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-vvfq-8hwr-qm4m
          CVE:             GHSA-vvfq-8hwr-qm4m
          Severity:

Check failure on line 38 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L38 

          nokogiri
          Warning Message: https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-vvfq-8hwr-qm4m
          CVE:             GHSA-vvfq-8hwr-qm4m
          Severity:

Check failure on line 38 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L38 

          nokogiri
          Warning Message: https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-vvfq-8hwr-qm4m
          CVE:             GHSA-vvfq-8hwr-qm4m
          Severity:
nokogiri (>= 1.8.5)
racc

Check failure on line 40 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L40 

          rack
          Warning Message: https://github.com/rack/rack/security/advisories/GHSA-cj83-2ww7-mvq7
          CVE:             CVE-2024-39316
          Severity:        medium

Check failure on line 40 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L40 

          rack
          Warning Message: https://github.com/rack/rack/security/advisories/GHSA-7g2v-jj9q-g3rg
          CVE:             CVE-2025-25184
          Severity:
rack (>= 2.2.4)
rack-session (>= 1.0.1)
rack-test (>= 0.6.3)
rails-dom-testing (~> 2.2)

Check failure on line 44 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L44 

          rails-html-sanitizer
          Warning Message: https://github.com/rails/rails-html-sanitizer/security/advisories/GHSA-w8gc-x259-rc7x
          CVE:             CVE-2024-53985
          Severity:

Check failure on line 44 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L44 

          rails-html-sanitizer
          Warning Message: https://github.com/rails/rails-html-sanitizer/security/advisories/GHSA-638j-pmjw-jq48
          CVE:             CVE-2024-53986
          Severity:

Check failure on line 44 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L44 

          rails-html-sanitizer
          Warning Message: https://github.com/rails/rails-html-sanitizer/security/advisories/GHSA-2x5m-9ch4-qgrr
          CVE:             CVE-2024-53987
          Severity:

Check failure on line 44 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L44 

          rails-html-sanitizer
          Warning Message: https://github.com/rails/rails-html-sanitizer/security/advisories/GHSA-cfjx-w229-hgx5
          CVE:             CVE-2024-53988
          Severity:

Check failure on line 44 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L44 

          rails-html-sanitizer
          Warning Message: https://github.com/rails/rails-html-sanitizer/security/advisories/GHSA-rxv5-gxqc-xx8g
          CVE:             CVE-2024-53989
          Severity:
rails-html-sanitizer (~> 1.6)

Check failure on line 45 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L45 

          actiontext
          Warning Message: https://github.com/rails/rails/security/advisories/GHSA-wwhv-wxv9-rpgw
          CVE:             CVE-2024-47888
          Severity:
actiontext (7.1.3.4)
actionpack (= 7.1.3.4)
activerecord (= 7.1.3.4)
Expand Down Expand Up @@ -86,7 +86,7 @@
bundler
rake
thor (>= 0.14.0)
appraisal-matrix (0.1.0)
appraisal-matrix (0.3.0)
appraisal (~> 2.2)
base64 (0.2.0)
bigdecimal (3.1.8)
Expand Down Expand Up @@ -152,7 +152,7 @@
rack-test (2.1.0)
rack (>= 1.3)
rackup (2.1.0)
rack (>= 3)

Check failure on line 155 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L155 

          webrick
          Warning Message: https://github.com/advisories/GHSA-6f62-3596-g6w7
          CVE:             CVE-2024-47220
          Severity:        high
webrick (~> 1.8)
rails (7.1.3.4)
actioncable (= 7.1.3.4)
Expand Down Expand Up @@ -193,7 +193,7 @@
sqlite3 (1.7.3-x86_64-darwin)
sqlite3 (1.7.3-x86_64-linux)
stringio (3.1.1)
thor (1.3.1)
thor (1.3.2)
timeout (0.4.1)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
Expand Down
18 changes: 0 additions & 18 deletions gemfiles/rails_6_0.gemfile
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions gemfiles/rails_6_1.gemfile
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion gemfiles/rails_7_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ gem "appraisal"
gem "appraisal-matrix"
gem "pry"
gem "rake"
gem "sqlite3", "~> 1.4"
gem "sqlite3"
gem "minitest"
gem "minitest-reporters"
gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_7_2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ gem "appraisal"
gem "appraisal-matrix"
gem "pry"
gem "rake"
gem "sqlite3", "~> 1.4"
gem "sqlite3"
gem "minitest"
gem "minitest-reporters"
gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_8_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ gem "appraisal"
gem "appraisal-matrix"
gem "pry"
gem "rake"
gem "sqlite3", "~> 1.4"
gem "sqlite3"
gem "minitest"
gem "minitest-reporters"
gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
Expand Down