DTPORTAL-16140: Document that #execute_agi_command returns nil upon hangup #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfgeorge
force-pushed
the
DTPORTAL-16140-detect-hangup-in-execute_agi_command
branch
2 times, most recently
from
250a4e6 to
24328b9
Compare
sfgeorge
changed the title
Author
|
Since this PR is whittled down to no longer change functionality, and merely to document & enhance specs, I'll close this PR and open it on the upstream adhearsion/adhearsion repo instead. |
sfgeorge
force-pushed
the
DTPORTAL-16140-detect-hangup-in-execute_agi_command
branch
from
24328b9 to
9c10a5e
Compare
Author
|
lol, whoops. This only makes sense here at the moment. The upstream adhearsion doesn't have the protection that our fork has to ensure that hungup calls correctly send a nil event in order to cause |
Author
|
Closing (again) in favor of #21. 🚪🐈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that #execute_agi_command returns nil upon hangup.