Certifier: bundle README.md with generated Agda certificate#7748
Certifier: bundle README.md with generated Agda certificate#7748ana-pantilie wants to merge 8 commits into
Conversation
zliu41
left a comment
There was a problem hiding this comment.
All these backslashes makes this quite hard to maintain. This is mostly static text, the only dynamic part is name, but I don't think you really need it to be dynamic. You can just make a static readme and load it with file-embed.
|
Even if you really want the dynamic |
zliu41
left a comment
There was a problem hiding this comment.
I'm not sure if data-files works. @zeme-wana What do you think? You mentioned this before about data-files:
They do in CI. But once the executable is built and deployed to some machine, the files are nowhere to be found
In any case, this is exactly what file-embed is designed to do, and that definitely works.
zliu41
left a comment
There was a problem hiding this comment.
Yeah, since we release uplc as a single executable, this can't work. You need to use file-embed.
1967f3c to
96add23
Compare
|
@zliu41 I'm now getting https://ci.iog.io/build/12767781/nixlog/18 which I'm unable to reproduce locally. @zeme-wana said that there might be platform specific issues with this approach, so I'm going to just use the original version, which was to embed the file into a Haskell string. It's much simpler, the file isn't that large, we won't have to change it too often and I think we've already spent too much time on this. |
What platform issues - can you elaborate? We use TH to load the cost model JSON files and there's no problem with that. |
|
@zliu41 The message I got from @zeme-wana regarding platform specific issues is that it might break CI on Windows. I did not get to see if this error would happen or not, because I got a different error (https://ci.iog.io/build/12767781/nixlog/18) which I also mentioned in the previous message. I wasn't able to reproduce this error locally, and it seemed to me like, given the issue and other potential issues, we should opt for the simplest solution. |
Your error is because you didn't add the md file to
@zeme-wana this is no longer a problem, which is why we decided to keep |
Fixes https://github.com/IntersectMBO/plutus-private/issues/2185