Value costing: insertCoin, unionValue, scaleValue #7435

ana-pantilie · 2025-11-19T21:31:35Z

Fixes https://github.com/IntersectMBO/plutus-private/issues/1899
Fixes https://github.com/IntersectMBO/plutus-private/issues/1900
Fixes https://github.com/IntersectMBO/plutus-private/issues/2004

See https://plutus.cardano.intersectmbo.org/pr-preview/cost-models/pr-7435/ for cost model vizualizations

plutus-core/plutus-core/src/PlutusCore/Evaluation/Machine/CostingFun/SimpleJSON.hs

plutus-core/cost-model/budgeting-bench/Benchmarks/Values.hs

plutus-core/cost-model/data/builtinCostModelC.json

plutus-core/cost-model/create-cost-model/BuiltinMemoryModels.hs

…s larger

plutus-core/plutus-core/src/PlutusCore/Value.hs

plutus-core/plutus-core/src/PlutusCore/Default/Builtins.hs

plutus-core/cost-model/data/builtinCostModelC.json

plutus-core/plutus-core/src/PlutusCore/Default/Builtins.hs

plutus-core/cost-model/budgeting-bench/Benchmarks/Values.hs

plutus-core/cost-model/create-cost-model/BuiltinMemoryModels.hs

plutus-core/cost-model/data/builtinCostModelC.json

plutus-core/cost-model/create-cost-model/BuiltinMemoryModels.hs

zliu41

The Value builtins should now be added to PlutusLedgerApi.Common.Versions.

plutus-core/cost-model/create-cost-model/BuiltinMemoryModels.hs

plutus-core/cost-model/data/builtinCostModelC.json

…inal

zliu41

Looks good but we need @kwxm to sign off on this.

plutus-core/cost-model/data/builtinCostModelC.json

kwxm

Here are some initial comments; I'll continue to review the PR (in particular, the benchmarking code: it's going to take me a while to grasp the details of that) and add more comments later. It all looks pretty sensible so far though.

plutus-core/plutus-core/src/PlutusCore/Evaluation/Machine/CostingFun/Core.hs

plutus-core/cost-model/data/models.R

plutus-core/cost-model/print-cost-model/Main.hs

kwxm · 2026-01-06T02:24:22Z

plutus-core/cost-model/data/models.R

    unValueDataModel          <- linearInX ("UnValueData")
+
+    # Y wrapped with `TotalSize` (contained value size)
+    scaleValueModel           <- linearInY ("ScaleValue")


I'm still puzzled by the shape of the data here, but making it linear in y does give a good overapproximation for all values of y. The downward bend at the start drags the regression line down quite a bit and you end up with a negavie intercept, but later that gets adjusted to 1000 and we end up with a line that lies just above all of the benchmark times.

plutus-ledger-api/src/PlutusLedgerApi/Common/Versions.hs

kwxm

I've added some more comments. I still need to check the benchmarking code though (not that I expect any problems, since the benchmark results look quite reasonable).

plutus-ledger-api/src/PlutusLedgerApi/V1/ParamName.hs

plutus-core/cost-model/budgeting-bench/Main.hs

plutus-core/plutus-core/src/PlutusCore/Value.hs

plutus-core/cost-model/budgeting-bench/Common.hs

kwxm

This looks pretty much OK. I've added quite a lot of minor comments, and I think the memory cost for scaleValue needs to be updated.

plutus-core/cost-model/budgeting-bench/Benchmarks/Values.hs

kwxm · 2026-01-07T02:29:53Z

plutus-core/cost-model/budgeting-bench/Benchmarks/Values.hs

+----------------------------------------------------------------------------------------------------
+-- ScaleValue --------------------------------------------------------------------------------------
+
+scaleValueBenchmark :: StdGen -> Benchmark


I'd still like to work oout why the graph is that odd shape (curved at first but then straightening out). The benchmark inputs look perfectly reasonable, so it's a bit mystifying. I don't think we need to let that hold us up though.

plutus-core/cost-model/create-cost-model/BuiltinMemoryModels.hs

This was referenced Nov 19, 2025

Costing builtin value: insertCoin, unionValue, scaleValue #7423

Closed

BuiltinValue: insertCoin and unionValue and scaleValue costing #7384

Closed

This comment was marked as outdated.

Sign in to view

ana-pantilie changed the title ~~Value costing: insertCoin, unionValue~~ Value costing: insertCoin, unionValue, scaleValue Nov 20, 2025

This comment was marked as outdated.

Sign in to view

ana-pantilie force-pushed the ana/value-costing-final branch 3 times, most recently from 1e44958 to abdc6ed Compare December 5, 2025 14:15

zliu41 reviewed Dec 8, 2025

View reviewed changes

plutus-core/plutus-core/src/PlutusCore/Evaluation/Machine/CostingFun/SimpleJSON.hs Outdated Show resolved Hide resolved

plutus-core/cost-model/budgeting-bench/Benchmarks/Values.hs Outdated Show resolved Hide resolved

ana-pantilie commented Dec 15, 2025

View reviewed changes

plutus-core/cost-model/data/builtinCostModelC.json Outdated Show resolved Hide resolved

ana-pantilie commented Dec 16, 2025

View reviewed changes

plutus-core/cost-model/create-cost-model/BuiltinMemoryModels.hs Outdated Show resolved Hide resolved

ana-pantilie added 18 commits December 18, 2025 18:59

Add insertCoin and unionValue costing skeleton

d897a75

Add benchmarking code and costing model for insertCoin

3ed4321

Add benchmarking code and costing model for unionValue

9b566bd

New models for insertCoin and unionValue; regenerate data

ab1312b

Fix model parsing and printing, wip scaleValue

54557fe

Fix issues with rebase

61d398b

Temp: experimenting with different inputs for unionValue

c81b534

Fix unionValue: shortcircuit if one is empty, flip args when second i…

a464a1c

…s larger

Add alternative implementation for unionValue

b74c996

Add new benchmarking scenarios

7d79538

Tmp: scaleValue costing

a4a95bb

UnionValue + ScaleValue generators, changes to unionValue builtin

bf67123

Data frames scaleVal unionValFInal

1fe564a

Add model for unionValue

9afbe70

Add cost models for insertCoin and unionValue

fcb377d

Remove experimental csv files and frames

0f47947

Fix cost model json

ed707b0

Fix cost models

c702815

ana-pantilie temporarily deployed to github-pages December 18, 2025 20:10 — with GitHub Actions Inactive

Add newtypes to denotations and regenerate golden files

c9fc008

ana-pantilie temporarily deployed to github-pages December 19, 2025 15:05 — with GitHub Actions Inactive

zliu41 reviewed Dec 20, 2025

View reviewed changes

Address review comments

d529ba8

ana-pantilie temporarily deployed to github-pages December 20, 2025 13:36 — with GitHub Actions Inactive

ana-pantilie requested a review from zliu41 December 20, 2025 13:38

zliu41 reviewed Dec 23, 2025

View reviewed changes

zliu41 reviewed Dec 24, 2025

View reviewed changes

plutus-core/cost-model/create-cost-model/BuiltinMemoryModels.hs Outdated Show resolved Hide resolved

plutus-core/cost-model/create-cost-model/BuiltinMemoryModels.hs Outdated Show resolved Hide resolved

plutus-core/cost-model/data/builtinCostModelC.json Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/master' into ana/value-costing-f…

78b9e7f

…inal

ana-pantilie temporarily deployed to github-pages December 24, 2025 11:17 — with GitHub Actions Inactive

Add Value builtins to batch 6

85d1aa9

ana-pantilie temporarily deployed to github-pages December 24, 2025 11:41 — with GitHub Actions Inactive

Address review comments

c411ba4

ana-pantilie temporarily deployed to github-pages December 24, 2025 12:15 — with GitHub Actions Inactive

ana-pantilie requested a review from zliu41 December 24, 2025 13:07

zliu41 approved these changes Dec 25, 2025

View reviewed changes

plutus-core/cost-model/data/builtinCostModelC.json Outdated Show resolved Hide resolved

kwxm reviewed Jan 5, 2026

View reviewed changes

plutus-core/cost-model/print-cost-model/Main.hs Outdated Show resolved Hide resolved

kwxm reviewed Jan 6, 2026

View reviewed changes

plutus-ledger-api/src/PlutusLedgerApi/Common/Versions.hs Outdated Show resolved Hide resolved

kwxm reviewed Jan 6, 2026

View reviewed changes

kwxm requested changes Jan 7, 2026

View reviewed changes

kwxm added Builtins Costing Anything relating to costs, fees, gas, etc. labels Jan 8, 2026

kwxm mentioned this pull request Jan 8, 2026

Refined memory/cpu cost models for ValueData and UnValueData #7500

Open

Address review comments

35fb719

ana-pantilie had a problem deploying to github-pages January 9, 2026 12:40 — with GitHub Actions Failure

ana-pantilie requested a review from kwxm January 9, 2026 12:43

ana-pantilie had a problem deploying to github-pages January 9, 2026 12:46 — with GitHub Actions Failure

Value costing: insertCoin, unionValue, scaleValue #7435

Are you sure you want to change the base?

Value costing: insertCoin, unionValue, scaleValue #7435

Conversation

ana-pantilie commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zliu41 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zliu41 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kwxm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kwxm Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kwxm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kwxm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kwxm Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ana-pantilie commented Nov 19, 2025 •

edited

Loading

kwxm left a comment •

edited

Loading