fix(cluster): merge stderr with stdout in run_command #3266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `run_command` helper to support merging stderr with stdout using the `merge_stderr` parameter. This ensures error output is captured in the same stream, improving logging and debugging. Applied in `start_cluster` to simplify cluster startup diagnostics.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the run_command helper function to support merging stderr with stdout by adding a merge_stderr parameter. This allows error output to be captured in the same stream as standard output, simplifying logging and debugging workflows, particularly for cluster operations.
Key Changes:
- Added
merge_stderrparameter torun_commandfunction with default valueFalse - Updated subprocess handling to conditionally redirect stderr to stdout
- Simplified error message construction logic
- Applied
merge_stderr=Trueinstart_clusterto consolidate cluster startup output
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cardano_node_tests/utils/helpers.py | Added merge_stderr parameter to run_command and updated subprocess configuration to merge stderr with stdout when enabled |
| cardano_node_tests/utils/cluster_nodes.py | Updated start_cluster to use merge_stderr=True for improved diagnostics |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
run_commandhelper to support merging stderr with stdout using themerge_stderrparameter. This ensures error output is captured in the same stream, improving logging and debugging. Applied instart_clusterto simplify cluster startup diagnostics.