update compatible tests #3255
Draft
update compatible tests #3255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoura
requested changes
Dec 16, 2025
|
|
||
| print("\n >>>>> ERROR START") | ||
| print(err) | ||
| print(" >>>>> ERROR END\n") |
Collaborator
There was a problem hiding this comment.
The prints are not needed.
|
|
||
| assert "TextEnvelope type error" in err, err | ||
| assert "Expected: CertificateConway" in err, err | ||
| assert "Actual: UpdateProposalShelley" in err, err |
Collaborator
There was a problem hiding this comment.
For single error string, assert single substring or regular expression search.
| "babbage": ("--max-collateral-inputs", 4, "maxCollateralInputs"), | ||
| } | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
This should be in the class where it is used.
|
|
||
| @allure.link(helpers.get_vcs_link()) | ||
| @submit_utils.PARAM_SUBMIT_METHOD | ||
| @pytest.mark.parametrize("era", ["shelley", "mary", "alonzo", "babbage"]) |
Collaborator
There was a problem hiding this comment.
Use tuple (immutable data) instead of list here.
| out_file = f"{temp_template}_update.proposal" | ||
| print("\nERROR MESSAGE START") | ||
| print(err_str) | ||
| print(" ERROR MESSAGE END\n") |
Collaborator
There was a problem hiding this comment.
The prints are not needed.
| err_str = str(excinfo.value) | ||
| assert "Invalid argument `create-update-proposal'" in err_str, err_str | ||
| assert "TextEnvelope type error" in err_str | ||
| assert "UpdateProposalShelley" in err_str |
Collaborator
There was a problem hiding this comment.
For single error string, assert single substring or regular expression search.
| @pytest.mark.parametrize( | ||
| "mir_cert", | ||
| ("to_treasury", "to_rewards", "treasury_to_addr", "reserves_to_addr"), | ||
| ) |
Collaborator
There was a problem hiding this comment.
Parametrize each test, not test class.
| Expect failure. | ||
| def test_mir_certificates(self, cluster, payment_addr, era, mir_cert): | ||
| """ | ||
| Try each MIR certificate across all compatible eras. |
Collaborator
There was a problem hiding this comment.
Use google style (numpy style) docstrings.
| reqc.cip070.success() | ||
|
|
||
|
|
||
| reqc.cip070.success() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update compatible tests