Open
Conversation
palas
requested review from
Jimbo4350,
carbolymer,
disassembler,
kevinhammond and
newhoggy
as code owners
There was a problem hiding this comment.
Pull request overview
Adds CLI support for generating and hashing node operational BLS keys, along with help-text goldens and dependency pinning needed to build against the required cardano-api changes.
Changes:
- Introduce
node key-gen-BLSandnode key-hash-BLScommands (and equivalents underlatest/conway). - Wire new commands through CLI option parsing, command types, and runtime handlers.
- Update golden help outputs and pin
cardano-apiviasource-repository-packageincabal.project.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| cardano-cli/src/Cardano/CLI/EraIndependent/Node/Run.hs | Implements BLS key generation and key hashing command handlers. |
| cardano-cli/src/Cardano/CLI/EraIndependent/Node/Option.hs | Adds optparse-applicative parsers for key-gen-BLS and key-hash-BLS. |
| cardano-cli/src/Cardano/CLI/EraIndependent/Node/Command.hs | Introduces new command constructors and argument records for BLS commands. |
| cardano-cli/src/Cardano/CLI/EraIndependent/Key/Run.hs | Extends key-type handling to include BLS verification keys in relevant command paths. |
| cardano-cli/test/cardano-cli-golden/files/golden/help/*.cli | Adds/updates golden help text for the new BLS node subcommands across eras. |
| cabal.project | Pins cardano-api from Git to pick up required upstream changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
palas
force-pushed
the
bls-key-gen-and-hash
branch
3 times, most recently
from
e037d45 to
4f5df59
Compare
Use `writeTextFileWithOwnerPermissions` instead of `writeTextFile` for the signing key
Drop the `:: () =>` constraint from `runNodeKeyGenBLSCmd` and `runNodeKeyHashBlsCmd` signatures
Use default for the description of the text envelope
palas
force-pushed
the
bls-key-gen-and-hash
branch
from
4f5df59 to
23272b2
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This addresses the first part of: input-output-hk/ouroboros-leios#776
This is based on
cardano-apichanges of PR: IntersectMBO/cardano-api#1148How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist