Refactor RL disagg producer flow with deeper manager-side abstraction#1769
Open
jayhenry wants to merge 11 commits intoInternLM:rl_designfrom
Open
Refactor RL disagg producer flow with deeper manager-side abstraction#1769jayhenry wants to merge 11 commits intoInternLM:rl_designfrom
jayhenry wants to merge 11 commits intoInternLM:rl_designfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR simplifies the RL disaggregated producer/consumer flow by moving repeated operational details into the right local abstractions. The goal is to make
AgentLoopManagerfocus on orchestration, while progress accounting, replay buffer operations, strategy context, and async pending-taskconcurrency are handled by dedicated components.
Changes
ProduceProgressReplayBufferAgentLoopManager.ProduceContextProduceStrategy._PendingTasksAsyncProduceStrategy.AgentLoopManagerto useProduceStrategy.pending_task_count()instead of reading strategy private state.AgentLoopManager_produce_batch_to_bufferby making callers provide task batch sizes explicitly.Why
These changes reduce hidden invariants and duplicated control flow.
AgentLoopManagerno longer needs to know how progress is accumulated, how replay buffer state is queried, how generated groups are normalized before put, or how async pending tasks are safely claimed. This makes thedisaggregated rollout path easier to reason about and safer to extend.