fix(ci): update lmdeploy commit in Dockerfile and fix some ci image version problems#1757
Open
CyCle1024 wants to merge 3 commits intoInternLM:mainfrom
Open
fix(ci): update lmdeploy commit in Dockerfile and fix some ci image version problems#1757CyCle1024 wants to merge 3 commits intoInternLM:mainfrom
CyCle1024 wants to merge 3 commits intoInternLM:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Docker build and deployment workflow to use newer dependencies and improves the way Docker images are tagged and pushed. The main changes involve upgrading the default PyTorch version, adjusting LMDeploy installation, updating image registry handling, and refining image tagging conventions.
Dependency and version upgrades:
LMDEPLOY_VERSIONtoLMDEPLOY_URLas the main build argument.Docker image registry and tagging improvements:
IMAGE_NAMEand now prepend the registry from secrets during the push step, improving flexibility and security.SHORT_DOCKER_TAGfor clarity and updatedSCHEDULE_TAGto reflect the new PyTorch version.Configuration and image usage updates:
autotest/config.yamltoailab-llmrazor/xtuner:pt29_latest, ensuring tests use the latest image built with the new workflow.Dependency management:
tilelangpackage to the Dockerfile's installation list, ensuring it is available in the build environment.