[Refactor] Refactor loss context API to support multiple loss types#1569
Open
HAOCHENYE wants to merge 2 commits intogh/HAOCHENYE/16/basefrom
Open
[Refactor] Refactor loss context API to support multiple loss types#1569HAOCHENYE wants to merge 2 commits intogh/HAOCHENYE/16/basefrom
HAOCHENYE wants to merge 2 commits intogh/HAOCHENYE/16/basefrom
Conversation
This was referenced Mar 12, 2026
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Mar 13, 2026
Change loss context from single object to dict-based API: - Update loss_cfg.build() to accept data parameter as dict - Change ModelItem.loss_ctx to dict with loss type keys (e.g. 'lm') - Update model forward pass to accept loss_ctx_dict parameter - Update all tests to use new dict-based loss context API ghstack-source-id: f3a7194 Pull-Request: InternLM#1569
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Mar 13, 2026
Change loss context from single object to dict-based API: - Update loss_cfg.build() to accept data parameter as dict - Change ModelItem.loss_ctx to dict with loss type keys (e.g. 'lm') - Update model forward pass to accept loss_ctx_dict parameter - Update all tests to use new dict-based loss context API ghstack-source-id: f3a7194 Pull-Request: InternLM#1569
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Mar 16, 2026
Change loss context from single object to dict-based API: - Update loss_cfg.build() to accept data parameter as dict - Change ModelItem.loss_ctx to dict with loss type keys (e.g. 'lm') - Update model forward pass to accept loss_ctx_dict parameter - Update all tests to use new dict-based loss context API ghstack-source-id: f3a7194 Pull-Request: InternLM#1569
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Mar 17, 2026
Change loss context from single object to dict-based API: - Update loss_cfg.build() to accept data parameter as dict - Change ModelItem.loss_ctx to dict with loss type keys (e.g. 'lm') - Update model forward pass to accept loss_ctx_dict parameter - Update all tests to use new dict-based loss context API ghstack-source-id: e27a1aa Pull-Request: InternLM#1569
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Change loss context from single object to dict-based API: