[Refactor] Extract common text context and labels building logic to reduce code duplication #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2026
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Jan 28, 2026
…educe code duplication ghstack-source-id: c1665c7 Pull-Request: InternLM#1453
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Jan 28, 2026
…educe code duplication ghstack-source-id: c1665c7 Pull-Request: InternLM#1453
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Jan 28, 2026
…educe code duplication ghstack-source-id: 67300b3 Pull-Request: InternLM#1453
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Jan 28, 2026
…educe code duplication ghstack-source-id: 67300b3 Pull-Request: InternLM#1453
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Jan 28, 2026
…educe code duplication ghstack-source-id: cf0d79c Pull-Request: InternLM#1453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
fullyshard in BaseModel` #1460chunk_losswhen backward with the frozelm_head#1458XTunerBaseModelConfig#1456DataloaderConfig#1454clean_param_name#1452SequenceContext#1451float8_handlerinfully_shared#1450