[WIP]: Support mtp fp8#4572
Open
RunningLeon wants to merge 2 commits intoInternLM:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PyTorch speculative-decoding (MTP draft) path to better support FP8-weight models by propagating model_format into spec-decode draft model construction and aligning Qwen3.5 MTP module behavior with FP8 checkpoint expectations.
Changes:
- Propagate
engine_config.model_formatintoSpecDecodeConfig.from_config()so draft/MTP models can be built with the same weight-quantization format. - Adjust Qwen3.5 MTP module prefixing and disable quantization for the MTP
fcprojection to match FP8 model configs. - Ensure spec-decode cache config inherits
quant_policyfrom the target cache config.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lmdeploy/pytorch/models/qwen3_5_mtp.py | Adjust MTP module prefixing and MTP fc quantization behavior for FP8 compatibility. |
| lmdeploy/pytorch/engine/config_builder.py | Forward model_format into spec-decode draft model config building. |
| lmdeploy/pytorch/config.py | Thread model_format through SpecDecodeConfig.from_config and carry quant_policy into spec-decode cache config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+103
to
107
| # do not quant fc as in https://huggingface.co/Qwen/Qwen3.5-27B-FP8/blob/main/config.json#L403 | ||
| # and https://huggingface.co/Qwen/Qwen3.5-35B-A3B-FP8/blob/main/config.json#L409 | ||
| self.fc = build_colwise_linear( | ||
| config.hidden_size * 2, | ||
| config.hidden_size, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist