support cache_seqlen on recurrent-gdr and causal-conv1d-update#4417
Open
grimoire wants to merge 7 commits intoInternLM:mainfrom
Open
support cache_seqlen on recurrent-gdr and causal-conv1d-update#4417grimoire wants to merge 7 commits intoInternLM:mainfrom
grimoire wants to merge 7 commits intoInternLM:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the CUDA TileLang kernels to support cache_seqlens-based circular-buffer semantics for (1) recurrent gated-delta-rule state updates and (2) causal_conv1d_update, and expands the test suite to exercise non-trivial sequence lengths and cache behavior.
Changes:
- Add
cache_seqlens/ circular-buffer support tofused_recurrent_gated_delta_rule(kernel + Python wrapper). - Add
cache_seqlens/ circular-buffer support tocausal_conv1d_update(kernel + Python wrapper). - Expand/parametrize kernel tests to cover
seqlen > 1, optionalcache_seqlens, and optional state indices.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
lmdeploy/pytorch/kernels/cuda/gated_delta_rule.py |
Extends recurrent GDR kernel/wrapper to handle multi-step seqlen and circular-buffer state addressing via cache_seqlens. |
lmdeploy/pytorch/kernels/cuda/causal_conv1d.py |
Extends causal_conv1d_update kernel/wrapper to optionally treat conv_state as a circular buffer addressed by cache_seqlens. |
tests/pytorch/kernel/test_gated_delta_rule.py |
Adds a new circular-buffer correctness test and expands seqlen parameterization. |
tests/pytorch/kernel/test_causal_conv1d.py |
Adjusts batch size and adds parameterization to test cache_seqlens and optional conv_state_indices. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist