Fix inconsistency in NPC answers about a person and their location#2713
Merged
KABoissonneault merged 1 commit intoInterkarma:masterfrom Mar 28, 2026
Merged
Conversation
Collaborator
|
The code change seems correct. |
KABoissonneault
approved these changes
Mar 28, 2026
Collaborator
KABoissonneault
left a comment
KABoissonneault
left a comment
There was a problem hiding this comment.
Change should be safe to merge, seems consistent with the other kind of DFU fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an old and annoying issue present in both classic DF and DFU, where an NPC wouldn't know the location of a building, but would still give information about that building when asked about an NPC located there, as in the example below.